From 33adf2e7b63a7303511b5b97ea3d28d333a0c8d4 Mon Sep 17 00:00:00 2001
From: Andrew Kroh <andrew.kroh@elastic.co>
Date: Tue, 22 Jun 2021 15:45:23 -0400
Subject: [PATCH] [Fleet] Add support for constant_keyword "value" in package
 field definitions

This enables Fleet to accept package field definitions that declare a constant "value"
for `constant_keyword` fields. Fleet will generate an index template for the constant_keyword
field that contains the `value` attribute.

Relates: https://github.com/elastic/package-spec/pull/194
---
 .../__snapshots__/template.test.ts.snap       |  4 ++++
 .../elasticsearch/template/template.test.ts   | 20 +++++++++++++++++++
 .../epm/elasticsearch/template/template.ts    |  6 ++++++
 .../fields/__snapshots__/field.test.ts.snap   |  5 +++++
 .../fleet/server/services/epm/fields/field.ts |  1 +
 .../server/services/epm/fields/tests/base.yml |  3 +++
 6 files changed, 39 insertions(+)

diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap
index acf8ae742bf8f1..815c7b44bea55a 100644
--- a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap
+++ b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap
@@ -87,6 +87,10 @@ exports[`EPM template tests loading base.yml: base.yml 1`] = `
         },
         "validarray": {
           "type": "integer"
+        },
+        "cycle_type": {
+          "type": "constant_keyword",
+          "value": "bicycle"
         }
       },
       "_meta": {
diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts
index ae7bff618dba2a..da1735f85fa5a6 100644
--- a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts
+++ b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts
@@ -611,6 +611,26 @@ describe('EPM template', () => {
     expect(JSON.stringify(mappings)).toEqual(JSON.stringify(constantKeywordMapping));
   });
 
+  it('tests constant_keyword field type with value', () => {
+    const constantKeywordLiteralYaml = `
+- name: constantKeyword
+  type: constant_keyword
+  value: always_the_same
+  `;
+    const constantKeywordMapping = {
+      properties: {
+        constantKeyword: {
+          type: 'constant_keyword',
+          value: 'always_the_same',
+        },
+      },
+    };
+    const fields: Field[] = safeLoad(constantKeywordLiteralYaml);
+    const processedFields = processFields(fields);
+    const mappings = generateMappings(processedFields);
+    expect(JSON.stringify(mappings)).toEqual(JSON.stringify(constantKeywordMapping));
+  });
+
   it('processes meta fields', () => {
     const metaFieldLiteralYaml = `
 - name: fieldWithMetas
diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
index 07d0df021c827b..a47c0c19606427 100644
--- a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
+++ b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
@@ -146,6 +146,12 @@ export function generateMappings(fields: Field[]): IndexTemplateMappings {
             fieldProps.fields = generateMultiFields(field.multi_fields);
           }
           break;
+        case 'constant_keyword':
+          fieldProps.type = field.type;
+          if (field.value) {
+            fieldProps.value = field.value;
+          }
+          break;
         case 'object':
           fieldProps = { ...fieldProps, ...generateDynamicAndEnabled(field), type: 'object' };
           break;
diff --git a/x-pack/plugins/fleet/server/services/epm/fields/__snapshots__/field.test.ts.snap b/x-pack/plugins/fleet/server/services/epm/fields/__snapshots__/field.test.ts.snap
index 5c402b896093a7..78f1fbc5286963 100644
--- a/x-pack/plugins/fleet/server/services/epm/fields/__snapshots__/field.test.ts.snap
+++ b/x-pack/plugins/fleet/server/services/epm/fields/__snapshots__/field.test.ts.snap
@@ -55,6 +55,11 @@ exports[`tests loading fields.yml: base.yml 1`] = `
     "name": "validarray",
     "type": "array",
     "object_type": "integer"
+  },
+  {
+    "name": "cycle_type",
+    "type": "constant_keyword",
+    "value": "bicycle"
   }
 ]
 `;
diff --git a/x-pack/plugins/fleet/server/services/epm/fields/field.ts b/x-pack/plugins/fleet/server/services/epm/fields/field.ts
index b8839b88bb78c7..9fa738aa60d098 100644
--- a/x-pack/plugins/fleet/server/services/epm/fields/field.ts
+++ b/x-pack/plugins/fleet/server/services/epm/fields/field.ts
@@ -15,6 +15,7 @@ export interface Field {
   name: string;
   type?: string;
   description?: string;
+  value?: string;
   format?: string;
   fields?: Fields;
   enabled?: boolean;
diff --git a/x-pack/plugins/fleet/server/services/epm/fields/tests/base.yml b/x-pack/plugins/fleet/server/services/epm/fields/tests/base.yml
index 5a71c7dee54dc0..ee7cd63539c155 100644
--- a/x-pack/plugins/fleet/server/services/epm/fields/tests/base.yml
+++ b/x-pack/plugins/fleet/server/services/epm/fields/tests/base.yml
@@ -20,4 +20,7 @@
   object_type: integer
 - name: invalidarray
   type: array
+- name: cycle_type
+  type: constant_keyword
+  value: bicycle