Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Java code coverage policy. #14191

Open
mashhurs opened this issue May 30, 2022 · 0 comments
Open

Apply Java code coverage policy. #14191

mashhurs opened this issue May 30, 2022 · 0 comments
Labels
enhancement status:needs-triage

Comments

@mashhurs
Copy link
Contributor

Description

It seems currently LS does not have Java code coverage settings (ruby has). It would improve the code quality and decrease the risk of issues being happen when new changes added. JaCoCo would be a good start but ES seems has a historical issue applying JaCoCo. We should first investigate how ES is accepting coverage for contributed codes and maybe keep similar way or apply similar concept (equal final coverage goal).

Acceptance Criteria

Add a coverage policy to allow build success if 90%+ (considering ES & Kibana rules) newly added lines are covered.
@mashhurs mashhurs changed the title Apply code coverage policy. Apply Java code coverage policy. May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status:needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mashhurs