Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy matching when filtering room list #14410

Open
Tracked by #21121
tulir opened this issue Jul 10, 2020 · 7 comments
Open
Tracked by #21121

Fuzzy matching when filtering room list #14410

tulir opened this issue Jul 10, 2020 · 7 comments
Labels
A-New-Search-Experience The new search dialog available in Labs A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@tulir
Copy link
Contributor

tulir commented Jul 10, 2020

Currently the room list filter only matches complete substrings. It would be nice if it did some fuzzy matching instead, so you could e.g. type the first few letters of each word in a multi-word room name instead of typing the whole thing.

There's an earlier issue for this too (#3216), but for some reason it was closed by matrix-org/matrix-react-sdk#3754 even though that PR only adds unhomoglyphing rather than fuzzy searching.

@t3chguy t3chguy assigned t3chguy and unassigned t3chguy Sep 28, 2020
@jryans jryans added the P1 label May 6, 2021
@germain-gg germain-gg self-assigned this Jun 14, 2021
@germain-gg germain-gg added the X-Needs-Product More input needed from the Product team label Jul 29, 2021
@kittykat kittykat added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 2, 2021
@t3chguy
Copy link
Member

t3chguy commented Feb 24, 2022

Applies also to the new search dialog

@t3chguy t3chguy added the A-New-Search-Experience The new search dialog available in Labs label Feb 24, 2022
@kittykat kittykat removed the P1 label Mar 31, 2022
@kittykat kittykat self-assigned this Mar 31, 2022
@germain-gg germain-gg removed the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label May 19, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 20, 2023

Closing in favour of #21640

@t3chguy t3chguy closed this as completed Feb 20, 2023
@MadLittleMods
Copy link
Contributor

Re-opening as this has more history, buy-in, and the other issue was already proposed to be closed. #21121 also mentions that this is the overarching issue.

@MadLittleMods MadLittleMods reopened this Feb 21, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 21, 2023

@MadLittleMods why reopen #21640 then?

@MadLittleMods
Copy link
Contributor

@t3chguy It looks like there was more activity from the author to maybe indicate that they saw value in it (included in #23365). Seems like the value tracking the design task separately.

@kittykat is #21640 useful to you anymore?

@weeman1337
Copy link
Contributor

weeman1337 commented Feb 27, 2023

Hey 👋 I really need fuzziness for the new search. It will save my nerves.

There is an issue about how to present it tot he user. I think the 100 % solution should provide feedback about why something is considered a search result.

Anyway what about implementing it without the visualisation hidden behind a labs setting?

For the algorithm I would give fzf a try. I am using it in many places and it provides good results.

@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2023

@weeman1337 at the very least a Netlify build to allow P&D to play with it and help guide further calls in this area would be grand.

@weeman1337 weeman1337 self-assigned this Mar 1, 2023
@weeman1337 weeman1337 removed their assignment Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Search-Experience The new search dialog available in Labs A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants