Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting button does not escape backticks #21437

Closed
robintown opened this issue Mar 16, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#8181
Closed

Code formatting button does not escape backticks #21437

robintown opened this issue Mar 16, 2022 · 4 comments · Fixed by matrix-org/matrix-react-sdk#8181
Assignees
Labels
A-Composer good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Type "hello ` world" in the composer
  2. Select all
  3. Press the code formatting button

Outcome

What did you expect?

For the backtick to be escaped by using more backticks for the fence, like this: ``hello ` world``

What happened instead?

The composer contains this text: `hello ` world`

Since the inner backtick is not escaped, sending the message results in:
hello world`
which was not the intent

Operating system

NixOS unstable

Browser information

Firefox 97.0.1

URL for webapp

develop.element.io

Application version

Element version: adad5e1-react-e677901eaf70-js-157635476bc0 Olm version: 3.2.8

Homeserver

Synapse 1.54.0

Will you send logs?

No

@robintown robintown added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer O-Uncommon Most users are unlikely to come across this or unexpected workflow O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 16, 2022
@t3chguy t3chguy added the good first issue Good for newcomers label Mar 22, 2022
@yaya-usman
Copy link
Contributor

@robintown how do i locate the composer? can you kindly drop a screenshot of the steps in reproducing the issue

@yaya-usman
Copy link
Contributor

@t3chguy @robintown , can you assign the issue to me?

@robintown
Copy link
Member Author

@yaya-usman It's the input box at the bottom of the screen, and the code formatting button is this one:

Screenshot 2022-03-28 at 08-17-25 Element Test room

@yaya-usman
Copy link
Contributor

@yaya-usman It's the input box at the bottom of the screen, and the code formatting button is this one:

Screenshot 2022-03-28 at 08-17-25 Element Test room

Yea figured it out, thanks. I am working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants