Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains containing Unicode codepoints not fully recognized even if protocol is included #24180

Closed
pludi opened this issue Jan 6, 2023 · 6 comments
Assignees
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Z-Upstream

Comments

@pludi
Copy link

pludi commented Jan 6, 2023

Steps to reproduce

In any chat include a URL containing Unicode codepoints outside alphabets. This was noticed with the URL http://↑↑↓↓←→←→ba.tk/

Outcome

What did you expect?

URL getting rendered as http://↑↑↓↓←→←→ba.tk/

What happened instead?

URL getting rendered as http://↑↑↓↓←→←→[ba.tk/](http://ba.tk/)

Example:

image

Operating system

Ubuntu, Mint

Browser information

No response

URL for webapp

app.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

@pludi pludi added the T-Defect label Jan 6, 2023
@pludi
Copy link
Author

pludi commented Jan 6, 2023

Possibly related to #5808 that needs to be fixed upstream in Hypercontext/linkifyjs

@turt2live turt2live added S-Tolerable Low/no impact on users A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 9, 2023
@t3chguy
Copy link
Member

t3chguy commented Jan 11, 2023

Indeed
image

@pludi
Copy link
Author

pludi commented Jan 16, 2023

Opened upstream ticket as Hypercontext/linkifyjs#427

@pludi
Copy link
Author

pludi commented Mar 27, 2023

Marked as fixed in version 4.1.1 upstream.

@t3chguy
Copy link
Member

t3chguy commented Mar 27, 2023

Blocked on #24589 then

@Johennes
Copy link
Contributor

We jumped to 4.1.1 with matrix-org/matrix-react-sdk#11132 and this seems fixed on nightly now.

Screenshot 2023-07-11 at 18 56 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Z-Upstream
Projects
None yet
Development

No branches or pull requests

4 participants