Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape keyboard shortcut no longer works #25641

Closed
andybalaam opened this issue Jun 21, 2023 · 2 comments
Closed

Escape keyboard shortcut no longer works #25641

andybalaam opened this issue Jun 21, 2023 · 2 comments
Labels
A-Composer A-Shortcuts Keyboard shortcuts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. In any room with unread messages in the main thread
  2. Press the Esc key on the keyboard

Outcome

What did you expect?

I expected the main thread to be marked as read, and to scroll to the bottom.

What happened instead?

Nothing happens, and this appears in the console:

XHRPOST
https://matrix-client.matrix.org/_matrix/client/r0/rooms/!jSkNtsjcsXfCRJwGpp:matrix.org/receipt/m.read/$jdyMMc9_UwOUF1BSRcGekTmiGQvl5kIswe-juMwiRvw
[HTTP/2 400 Bad Request 29ms]
Error sending receipt 
Object { room: "!jSkNtsjcsXfCRJwGpp:matrix.org", error: M_INVALID_PARAM }
rageshake.ts:74:27
    fnName rageshake.ts:74
    instrumentConsole instrument.js:113
    methodFactory logger.ts:48
    sendReadReceipt TimelinePanel.tsx:1193
    TimelinePanel_TimelinePanel TimelinePanel.tsx:1163
    updateReadReceiptOnUserActivity TimelinePanel.tsx:1018
    componentDidMount TimelinePanel.tsx:325
    React 2
    unstable_runWithPriority scheduler.production.min.js:18
    React 4
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    setState MatrixChat.tsx:415
    viewRoom MatrixChat.tsx:978
    MatrixChat MatrixChat.tsx:695
    invokeCallback dispatcher.ts:120
    MatrixDispatcher dispatcher.ts:97
    sentryWrapped helpers.js:92
    (Async: setTimeout handler)
    _wrapTimeFunction trycatch.js:107
    dispatch dispatcher.ts:170
    viewRoom RoomViewStore.tsx:507
    onDispatch RoomViewStore.tsx:263
    invokeCallback dispatcher.ts:120

Operating system

Ubuntu 22.04

Browser information

Firefox 114.0.1

URL for webapp

https://develop.element.io

Application version

Element version: 278c494-react-ad8543eb586f-js-8b9672ba43a2 Olm version: 3.2.14

Homeserver

matrix.org

Will you send logs?

Yes

@t3chguy
Copy link
Member

t3chguy commented Jun 21, 2023

@andybalaam is this #25640?

@andybalaam
Copy link
Contributor Author

@andybalaam is this #25640?

Yep

Duplicate of #25640

@andybalaam andybalaam closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer A-Shortcuts Keyboard shortcuts O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Shortcuts Keyboard shortcuts O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

3 participants