Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reCAPTCHA doesn't work on Riot/Desktop, so forces you to sign up on Riot/Web #4893

Closed
ssolidus opened this issue Aug 26, 2017 · 7 comments · Fixed by matrix-org/matrix-react-sdk#1340
Closed

reCAPTCHA doesn't work on Riot/Desktop, so forces you to sign up on Riot/Web #4893

ssolidus opened this issue Aug 26, 2017 · 7 comments · Fixed by matrix-org/matrix-react-sdk#1340
Labels
A-Electron A-Registration P2 T-Enhancement

Comments

@ssolidus
Copy link

Description

When trying to create an account, the captcha appears as [Object object]

Steps to reproduce

  • Open Riot desktop client
  • Attempt to create an account
  • Should produce captcha, instead comes up as [Object object] (see screenshot below)

Log/Screenshots:

Log not available

image

Version information

  • Platform: Desktop
  • OS: Windows 7 x64
  • Version: 0.12.2
@t3chguy
Copy link
Member

t3chguy commented Aug 26, 2017

What it's trying to say is that robot detection is not available on desktop but obviously failing
I'll take a look

@t3chguy
Copy link
Member

t3chguy commented Aug 26, 2017

The captcha lib doesn't work when the protocol is file:// as it is in Electron

@t3chguy
Copy link
Member

t3chguy commented Aug 26, 2017

Broken error fixed here: matrix-org/matrix-react-sdk#1340

@t3chguy
Copy link
Member

t3chguy commented Aug 26, 2017

I will leave this issue open to track the greater issue

@t3chguy t3chguy mentioned this issue Aug 26, 2017
Merged
@lampholder lampholder added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround P1 Z-Platform-Specific A-Electron and removed Z-Platform-Specific labels Aug 29, 2017
@ara4n ara4n added feature P2 A-Registration and removed T-Defect S-Critical Prevents work, causes data loss and/or has no workaround P1 labels Jan 19, 2018
@ara4n ara4n changed the title Cannot create new account through Riot desktop client reCAPTCHA doesn't work on Riot/Desktop, so forces you to sign up on Riot/Web Jan 19, 2018
@t3chguy t3chguy mentioned this issue May 28, 2018
Closed
@Ashaman-
Copy link

Additionally, attempts to sign up with captcha enabled on a forked version of riot-web which has a different default homeserver and identity server set are met with directions to register on the web client at riot.im. This should be a setting defined in config.json IMO.

@aaronraimist aaronraimist mentioned this issue Oct 27, 2018
Closed
@aaronraimist
Copy link
Collaborator

Wonder if reCAPTCHA v3 works better here
https://webmasters.googleblog.com/2018/10/introducing-recaptcha-v3-new-way-to.html

@turt2live turt2live mentioned this issue Jan 28, 2019
Closed
3 tasks
@jryans
Copy link
Collaborator

jryans commented Feb 19, 2019

It looks like captchas now work in Riot desktop, so I have made a change to allow them there. Hopefully that will continue to be true in production usage on all OSes.

@jryans jryans closed this as completed Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Electron A-Registration P2 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

_tJsx returns a React Object, the sub fn must return a React Object matrix-org/matrix-react-sdk
7 participants
@jryans @ara4n @lampholder @t3chguy @aaronraimist @Ashaman- @ssolidus