Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getRepository for Collections and Subcollections with the Same Name #25

Open
elersong opened this issue Jul 13, 2024 · 1 comment
Open
Labels
bug Something isn't working from_willyovale An issue described in original project, but never implemented

Comments

@elersong
Copy link
Owner

Description

When naming a collection and a subcollection with the same name, the getRepository function returns incorrect results. This issue arises due to the way getRepository prioritizes collections and subcollections.

Steps to Reproduce

  1. Create a collection and a subcollection with the same name.
  2. Use getRepository to retrieve the repository.
  3. Observe that the incorrect repository is returned.

Expected Behavior

The getRepository function should correctly distinguish between collections and subcollections with the same name, giving priority to collections.

Actual Behavior

The getRepository function returns the wrong repository when collections and subcollections have the same name.

Acceptance Criteria

  • Modify getRepository to rank collections first, giving them priority over subcollections.
  • Ensure the function correctly distinguishes between collections and subcollections with the same name.
  • Add unit tests to verify the correct behavior of getRepository in this scenario.

Additional Context

  • October 23, 2020: Initial issue raised about the incorrect behavior of getRepository.
  • November 8, 2020: Acknowledgment of the issue and suggestion to prioritize collections over subcollections.

Original Issue

@elersong elersong added bug Something isn't working from_willyovale An issue described in original project, but never implemented labels Jul 13, 2024
@elersong
Copy link
Owner Author

Possibly connected to #32

@elersong elersong assigned elersong and unassigned elersong Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working from_willyovale An issue described in original project, but never implemented
Projects
None yet
Development

No branches or pull requests

1 participant