Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Changes to submitSurveyResponse mutation #2309

Open
Cooryd opened this issue Jul 12, 2019 · 1 comment
Open

Changes to submitSurveyResponse mutation #2309

Cooryd opened this issue Jul 12, 2019 · 1 comment
Labels
Server-Side Any issue regarding the server side components.
Milestone
Demographic Quest...

Comments

@Cooryd
Copy link
Contributor

Cooryd commented Jul 12, 2019

Task

elife-xpub/packages/component-submission/server/typeDefs.graphqls

Line 12 in 7dbf988

submitSurvey(data: SurveySubmission!): Boolean!
the submitSurveyResponse mutation currently takes a single data variable which is type SurveySubmission, this adds a layer of abstraction which could be removed by having three variables sent as part of the mutation call.

We should also be returning a Survey object back on this call instead of a Boolean as this is best practice with graphql.
@Cooryd Cooryd added the Server-Side Any issue regarding the server side components. label Jul 12, 2019
@Cooryd Cooryd added this to the Demographic Questions milestone Jul 12, 2019
@diversemix
Copy link
Contributor

@Cooryd ... Would you like this to be done before the survey is released?

/cc @hdrury1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Server-Side Any issue regarding the server side components.
Projects
None yet
Milestone
Demographic Questions
Development

No branches or pull requests
2 participants
@diversemix @Cooryd