Server should check socket state before calling 'send' method

[coderNeos]

rpc-websockets/src/lib/server.js

Line 417 in 2f0f59e

return socket.send(CircularJSON.stringify(response), msg_options)

In case if client socket closes the connection - 'send' will cause an unhandled rejection, which in some production environments might lead to application crash!

Mentioned problem is relevant to any other socket.send call.

Steps to reproduce:

1. Call some long running rpc task
2. Close client connection
3. After task has finished - unhandledRejection will be triggered

[mkozjak]

Hi, @coderNeos! Thanks for reporting! Care to do a PR?

[coderNeos]

Hi, i think i will be able to fix that issue in my free time.

[mkozjak]

Thank you so much!

[lucaswxp]

Anyone got this?

[coderNeos]

Anyone got this?

Nope, i didn't have any spare time to address this issue

[mkozjak]

@lucaswxp: Wanna try providing a PR?

[mkozjak]

@coderNeos any updates on this one maybe?

[mkozjak]

websockets/ws#1532