Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken for test harness: recat dependencies unresolvable #1132

Closed
romeokienzler opened this issue Jul 27, 2022 · 5 comments
Closed

Build broken for test harness: recat dependencies unresolvable #1132

romeokienzler opened this issue Jul 27, 2022 · 5 comments
Assignees

Comments

@romeokienzler
Copy link
Member

romeokienzler commented Jul 27, 2022

Followed the documentation to build the test harness but on npm install in /home/ubuntu/canvas/canvas_modules/harness I get:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: canvas-demo@0.0.1
npm ERR! Found: react@16.13.1
npm ERR! node_modules/react
npm ERR! dev react@"16.13.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.0-rc.2" from @hot-loader/react-dom@17.0.0-rc.2
npm ERR! node_modules/@hot-loader/react-dom
npm ERR! dev @hot-loader/react-dom@"17.0.0-rc.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/ubuntu/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/ubuntu/.npm/_logs/2022-07-27T10_36_12_001Z-debug.log

When bumping react from 16.13.1 to 17.0.0-rc.2 in package.json, I get:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: canvas-demo@0.0.1
npm ERR! Found: react@17.0.0-rc.2
npm ERR! node_modules/react
npm ERR! dev react@"17.0.0-rc.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=16" from @carbon/icons-react@10.49.0
npm ERR! node_modules/@carbon/icons-react
npm ERR! dev @carbon/icons-react@"10.49.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/ubuntu/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR! /home/ubuntu/.npm/_logs/2022-07-27T10_30_26_399Z-debug.log

So I'd say carbon is pinning react to <= v16, correct?

@nmgokhale
Copy link
Member

@romeokienzler What is the node version? These errors are usually seen in node 16.x.
Elyra-canvas uses node 14.x

@romeokienzler
Copy link
Member Author

@nmgokhale 18.7.0 ;) thanks a lot! Will send an update tomorrow

@EMCP
Copy link

EMCP commented Jul 28, 2022

I can confirm, this is broken on nodejs 16.. backing off to v14 seems to repair things.. any idea on a timeline for support ?

@nmgokhale
Copy link
Member

nmgokhale commented Jul 28, 2022

npm install works fine for me on node version 14.20.0.

I will open an issue to upgrade to node 16.x. Until then, temporary workaround is running - npm install --legacy-peer-deps.

@nmgokhale nmgokhale self-assigned this Jul 28, 2022
@romeokienzler
Copy link
Member Author

Thanks a lot @nmgokhale, downgrading to Node v14.x works fine for me

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants