From 1e212ca9f0a141f12c3a598c04c6cfab2908478a Mon Sep 17 00:00:00 2001 From: Ed Page Date: Thu, 11 Jul 2024 16:27:54 -0500 Subject: [PATCH] fix(source): Don't warn about unreferenced duplicate packages Fixes #10752 --- src/cargo/sources/path.rs | 1 + tests/testsuite/git.rs | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/cargo/sources/path.rs b/src/cargo/sources/path.rs index 4f49171506e7..ce30af010834 100644 --- a/src/cargo/sources/path.rs +++ b/src/cargo/sources/path.rs @@ -323,6 +323,7 @@ impl<'gctx> Source for RecursivePathSource<'gctx> { for s in self .packages .iter() + .filter(|(pkg_id, _)| pkg_id.name() == dep.package_name()) .map(|(pkg_id, pkgs)| { first_package(*pkg_id, pkgs, &mut self.warned_duplicate, self.gctx) }) diff --git a/tests/testsuite/git.rs b/tests/testsuite/git.rs index 71a523d11d84..62e3fc29c17a 100644 --- a/tests/testsuite/git.rs +++ b/tests/testsuite/git.rs @@ -1283,10 +1283,6 @@ expected `.`, `]` 2 | [package | ^ | -[WARNING] skipping duplicate package `duplicate v0.5.0 ([ROOTURL]/dep#[..])`: - [ROOT]/home/.cargo/git/checkouts/dep-[HASH]/[..]/duplicate2/Cargo.toml -in favor of [ROOT]/home/.cargo/git/checkouts/dep-[HASH]/[..]/duplicate1/Cargo.toml - [FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s [RUNNING] `target/debug/foo[EXE]`