From 3911e7d9d1eab36e92d27c55bac971ed1a5575c9 Mon Sep 17 00:00:00 2001 From: Hidayat Hamir Date: Sat, 24 Feb 2024 17:04:43 +0700 Subject: [PATCH] fix: should not create new logger setup logrus only without create new logger what if our user want add hook? if we create new logger we need to handler to add hook. better to just let user keep using logrus we just add configuration --- eraspacelogruslogger.go | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/eraspacelogruslogger.go b/eraspacelogruslogger.go index 61c0634..bf6bce2 100644 --- a/eraspacelogruslogger.go +++ b/eraspacelogruslogger.go @@ -1,18 +1,13 @@ package eraspacelog import ( - "context" "os" "github.com/sirupsen/logrus" ) -var eraspaceLog *logrus.Logger - -type Fields = logrus.Fields - func SetupLogger(env string) { - loger := logrus.New() + logrus.New() formatter := Formatter{ ChildFormatter: &logrus.JSONFormatter{}, @@ -31,9 +26,9 @@ func SetupLogger(env string) { } } - loger.SetFormatter(&formatter) - loger.SetOutput(os.Stdout) - loger.SetLevel(logrus.InfoLevel) + logrus.SetFormatter(&formatter) + logrus.SetOutput(os.Stdout) + logrus.SetLevel(logrus.InfoLevel) otelHook := NewOtelTraceHook(&TraceHookConfig{ RecordStackTraceInSpan: true, @@ -41,10 +36,5 @@ func SetupLogger(env string) { ErrorSpanLevel: logrus.ErrorLevel, }) - eraspaceLog = loger - eraspaceLog.AddHook(otelHook) -} - -func WithContext(ctx context.Context, field map[string]interface{}) *logrus.Entry { - return eraspaceLog.WithContext(ctx).WithFields(field) + logrus.AddHook(otelHook) }