From a1aade8c1b06263516c64eb16126f8d3ad4391cd Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Wed, 23 May 2018 13:09:31 -0700 Subject: [PATCH] etcdserver: rename to "heartbeat_send_failures_total" Signed-off-by: Gyuho Lee --- etcdserver/metrics.go | 8 ++++---- etcdserver/raft.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/etcdserver/metrics.go b/etcdserver/metrics.go index 6bdc0a7a659..b1f85e78ff6 100644 --- a/etcdserver/metrics.go +++ b/etcdserver/metrics.go @@ -42,11 +42,11 @@ var ( Name: "leader_changes_seen_total", Help: "The number of leader changes seen.", }) - heartbeatFailures = prometheus.NewCounter(prometheus.CounterOpts{ + heartbeatSendFailures = prometheus.NewCounter(prometheus.CounterOpts{ Namespace: "etcd", Subsystem: "server", - Name: "heartbeat_failures_total", - Help: "The total number of heartbeat send failures (likely overloaded from slow disk).", + Name: "heartbeat_send_failures_total", + Help: "The total number of leader heartbeat send failures (likely overloaded from slow disk).", }) slowApplies = prometheus.NewCounter(prometheus.CounterOpts{ Namespace: "etcd", @@ -97,7 +97,7 @@ func init() { prometheus.MustRegister(hasLeader) prometheus.MustRegister(isLeader) prometheus.MustRegister(leaderChanges) - prometheus.MustRegister(heartbeatFailures) + prometheus.MustRegister(heartbeatSendFailures) prometheus.MustRegister(slowApplies) prometheus.MustRegister(proposalsCommitted) prometheus.MustRegister(proposalsApplied) diff --git a/etcdserver/raft.go b/etcdserver/raft.go index 089985c75d0..d53bf2efd5b 100644 --- a/etcdserver/raft.go +++ b/etcdserver/raft.go @@ -368,7 +368,7 @@ func (r *raftNode) processMessages(ms []raftpb.Message) []raftpb.Message { // TODO: limit request rate. if r.lg != nil { r.lg.Warn( - "failed to send out heartbeat; took too long, server is overloaded likely from slow disk", + "leader failed to send out heartbeat on time; took too long, leader is overloaded likely from slow disk", zap.Duration("heartbeat-interval", r.heartbeat), zap.Duration("expected-duration", 2*r.heartbeat), zap.Duration("exceeded-duration", exceed), @@ -377,7 +377,7 @@ func (r *raftNode) processMessages(ms []raftpb.Message) []raftpb.Message { plog.Warningf("failed to send out heartbeat on time (exceeded the %v timeout for %v)", r.heartbeat, exceed) plog.Warningf("server is likely overloaded") } - heartbeatFailures.Inc() + heartbeatSendFailures.Inc() } } }