From fbdf65f1015acd278e36cdf484bc909e8033a176 Mon Sep 17 00:00:00 2001 From: Marek Siarkowicz Date: Mon, 27 Nov 2023 12:00:12 +0100 Subject: [PATCH] Test v3 storage configuration validation Signed-off-by: Marek Siarkowicz --- server/etcdserver/api/membership/cluster_test.go | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/server/etcdserver/api/membership/cluster_test.go b/server/etcdserver/api/membership/cluster_test.go index 9589ba24c9d..e03c19a4cbb 100644 --- a/server/etcdserver/api/membership/cluster_test.go +++ b/server/etcdserver/api/membership/cluster_test.go @@ -276,8 +276,17 @@ func TestClusterValidateAndAssignIDs(t *testing.T) { } } -func TestClusterValidateConfigurationChange(t *testing.T) { +func TestClusterValidateConfigurationChangeV3(t *testing.T) { + testClusterValidateConfigurationChange(t, true) +} +func TestClusterValidateConfigurationChangeV2(t *testing.T) { + testClusterValidateConfigurationChange(t, false) +} + +func testClusterValidateConfigurationChange(t *testing.T, shouldApplyV3 ShouldApplyV3) { cl := NewCluster(zaptest.NewLogger(t), WithMaxLearners(1)) + be := newMembershipBackend() + cl.SetBackend(be) cl.SetStore(v2store.New()) for i := 1; i <= 4; i++ { var isLearner bool @@ -455,7 +464,7 @@ func TestClusterValidateConfigurationChange(t *testing.T) { }, } for i, tt := range tests { - err := cl.ValidateConfigurationChange(tt.cc, false) + err := cl.ValidateConfigurationChange(tt.cc, shouldApplyV3) if err != tt.werr { t.Errorf("#%d: validateConfigurationChange error = %v, want %v", i, err, tt.werr) }