Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defrag unsets backend options #13678

Closed
lavacat opened this issue Feb 10, 2022 · 2 comments · Fixed by #13679
Closed

Defrag unsets backend options #13678

lavacat opened this issue Feb 10, 2022 · 2 comments · Fixed by #13679
Labels

Comments

@lavacat
Copy link

lavacat commented Feb 10, 2022

What happened?

After running defrag backend options will be unset. For example FreelistType will be ""

What did you expect to happen?

Defrag should preserve original backend options

How can we reproduce it (as minimally and precisely as possible)?

See unit test in PR.

Anything else we need to know?

No response

Etcd version (please run commands below)

affects 3.5 and 3.4 releases

Etcd configuration (command line flags or environment variables)

paste your configuration here

Etcd debug information (please run commands blow, feel free to obfuscate the IP address or FQDN in the output)

$ etcdctl member list -w table
# paste output here

$ etcdctl --endpoints=<member list> endpoint status -w table
# paste output here

Relevant log output

No response

@serathius
Copy link
Member

serathius commented Feb 13, 2022

Thanks for sending PR, can you create a backport PRs to 3.5 and 3.4 after merge?

@lavacat
Copy link
Author

lavacat commented Feb 14, 2022

Thanks for sending PR, can you create a backport PRs to 3.5 and 3.4 after merge?

Yes, I'll submit similar PRs for 3.5 and 3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants