Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining gofailpoints in linearizability tests #14726

Closed
7 tasks done
serathius opened this issue Nov 10, 2022 · 3 comments · Fixed by #15104
Closed
7 tasks done

Implement remaining gofailpoints in linearizability tests #14726

serathius opened this issue Nov 10, 2022 · 3 comments · Fixed by #15104
Assignees
Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@serathius
Copy link
Member

serathius commented Nov 10, 2022

What would you like to be added?

This is followup to #14687 that introduced triggering random failpoint.
Failpoints are injected by sending http request to modified etcd server that will panic on when it reaches specific part of code.
Problem is that some failpoints will not be naturally triggered and require additional action to server to reach the code. For example defragBeforeCopy and defragBeforeRename require starting a Defrag.

There are still failpoints that require implementing their triggers. Goal of this issue is to implement triggers for failpoints and adding them to RandomFailpoint which is used by automated testing. Code: https://github.com/etcd-io/etcd/blob/main/tests/linearizability/failpoints.go#L33-L53

Failpoints to be implemented:

Why is this needed?

Increases the coverage of linearizability tests.

@serathius serathius added type/feature area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 10, 2022
@serathius serathius changed the title Implement remaining failpoints in linearizability tests Implement remaining gofailpoints in linearizability tests Nov 10, 2022
@lavacat
Copy link

lavacat commented Dec 15, 2022

@serathius please assign this to me. I'm already working on all Snap endpoints. The way to reproduce is outlined here #10219.
I got it working within current framework using trigger hook, but sometimes it's flaky. Will submit draft pr after it's passing consistently.

@jmhbnz
Copy link
Member

jmhbnz commented Apr 24, 2023

Hey @serathius, @lavacat - Can this one be closed now?

I'm looking at the list of tasks on the issue and to me it looks like #15104 and #15268 completed all these tasks?

@serathius
Copy link
Member Author

Yep, looks like we are done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing help wanted priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

Successfully merging a pull request may close this issue.

3 participants