Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CGO_ENABLED Configurable #17419

Closed
ArkaSaha30 opened this issue Feb 13, 2024 · 2 comments
Closed

Make CGO_ENABLED Configurable #17419

ArkaSaha30 opened this issue Feb 13, 2024 · 2 comments
Assignees
Labels
backport/v3.4 backport/v3.5 priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@ArkaSaha30
Copy link
Contributor

What would you like to be added?

The value of CGO_ENABLED is hard-coded to 0. I would want to make CGO_ENABLED optionally configurable by passing an environment variable during runtime. When no environment variable is passed it will default to 0 therefore keeping the build process intact as defined in the script.

Ref: #17418

Why is this needed?

CGO_ENABLED is an important Environment Variable required during Go compilation and build process. Making it configurable will allow consumers to build etcd as per their requirements, specifically I have come across FIPS compilation requirement which requires the CGO_ENABLED=1. The suggested PR will not hinder the existing build process but allow users to configure CGO_ENABLED environment variable as per their requirement.

@jmhbnz jmhbnz added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 14, 2024
@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2024

@ArkaSaha30 Please add a changelog for both 3.5 and 3.4. thx

@ahrtr
Copy link
Member

ahrtr commented Feb 19, 2024

All done.

@ahrtr ahrtr closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v3.4 backport/v3.5 priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
Development

No branches or pull requests

3 participants