Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: improve retry policy #9171

Closed
gyuho opened this issue Jan 19, 2018 · 3 comments
Closed

clientv3: improve retry policy #9171

gyuho opened this issue Jan 19, 2018 · 3 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 19, 2018

#9165 (comment)

also it seems that the retry is pretty aggressive. for not capable error at least, we should not retry that aggressive, since we know it is because of the cluster is not fully up. retry immediately will not resolve that since it is different than a network error where a immediate retry has a high chance to just work.

from our side, we can retry not capable less aggressive, and we do not need to switch to another endpoint for not capable error too.

Along with dial policy #9157, retry policy needs some improvements.

Currently, it's just for-loop with no waiting.

@gyuho
Copy link
Contributor Author

gyuho commented Mar 27, 2018

We are redesigning client balancer interface and will support configurable retry policy.
/cc @yudai

@gyuho
Copy link
Contributor Author

gyuho commented May 17, 2018

Just as an update: we are making retry number configurable, in the process of rewriting balancer #9106. More fine-grained retry policy can be extended later.

@gyuho
Copy link
Contributor Author

gyuho commented Jun 15, 2018

Should be all fixed via #9860 and #9840. We may make it configurable once the official gRPC retries becomes stable.

@gyuho gyuho closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant