Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_fetcher.get_getrefdata returns duplicates #46

Open
clive3 opened this issue Feb 7, 2022 · 1 comment
Open

data_fetcher.get_getrefdata returns duplicates #46

clive3 opened this issue Feb 7, 2022 · 1 comment
Assignees
@gmaze @AndreaGarciaJuan
Labels
bug Something isn't working

Comments

@clive3
Copy link

clive3 commented Feb 7, 2022

this could be fixed by adding

# remove duplicates from list and sort into ascending order
boxes_list = sorted(list(set(boxes_list)))

at line 83
@kamwal kamwal assigned kamwal, gmaze and AndreaGarciaJuan and unassigned kamwal Feb 7, 2022
@kamwal kamwal added the bug Something isn't working label Feb 7, 2022
@gmaze
Copy link
Member

gmaze commented Feb 7, 2022

Hi @clive3
apparently, this was done on purpose in the case where both argo and ctd reference data were used here

DMQC-PCM/PCM-design/PCM_utils_forDMQC/data_fetcher.py

Line 68 in 18c9e0d

# duplicate boxes list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmaze gmaze

@AndreaGarciaJuan AndreaGarciaJuan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gmaze @clive3 @kamwal @AndreaGarciaJuan