Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor function options management #79

Closed
gmaze opened this issue Sep 16, 2022 · 1 comment
Closed

Refactor function options management #79

gmaze opened this issue Sep 16, 2022 · 1 comment
Labels
invalid This doesn't seem right priority-low Low priority for next release refactoring improve the design, structure, and/or implementation

Comments

@gmaze
Copy link
Member

gmaze commented Sep 16, 2022

I noticed that some of the pyowc functions do not use the same options order policy !
For instance:

# Calculate mapped values needed for the analysis
owc.calibration.update_salinity_mapping("", USER_CONFIG, FLOAT_NAME)

while we have:

# Set the calseries parameters for analysis and line fitting
owc.configuration.set_calseries("", FLOAT_NAME, USER_CONFIG)

see how USER_CONFIG comes first and then second ...

when refactoring the code, this must be addressed.

@gmaze gmaze added invalid This doesn't seem right refactoring improve the design, structure, and/or implementation labels Sep 16, 2022
@kamwal kamwal added the priority-low Low priority for next release label Nov 7, 2022
@gmaze
Copy link
Member Author

gmaze commented Dec 8, 2022

closing because this is definitely deal with in #29 !

@gmaze gmaze closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority-low Low priority for next release refactoring improve the design, structure, and/or implementation
Projects
None yet
Development

No branches or pull requests

2 participants