Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the author_email in setup.py #80

Open
kamwal opened this issue Nov 8, 2022 · 3 comments · May be fixed by #82
Open

Change the author_email in setup.py #80

kamwal opened this issue Nov 8, 2022 · 3 comments · May be fixed by #82
Labels
priority-low Low priority for next release

Comments

@kamwal
Copy link
Contributor

kamwal commented Nov 8, 2022

Currently, in the setup.py code including the general information about the software the author email is edsmall@bodc.ac.uk
Ed Small is not working in BODC and it would be good to change this email to more general such as argo@bodc.ac.uk or any other

@kamwal kamwal added the priority-low Low priority for next release label Nov 8, 2022
@gmaze
Copy link
Member

gmaze commented Dec 7, 2022

This can be done very quickly, the question is to choose the most appropriate email !
Do you receive emails addressed to argo@bodc.ac.uk ?

@kamwal
Copy link
Contributor Author

kamwal commented Dec 7, 2022

Yes, this is a very minor change.
I think I tried to change is before and I hit some issue in the pylint checks.

argo@bodc.ac.uk is our general email and our entire BODC Argo team have access to it.

@gmaze
Copy link
Member

gmaze commented Dec 7, 2022

Ok, I'll push a PR to change this and ensure pylint tests are ok, but I don't see why it would not

@gmaze gmaze linked a pull request Dec 7, 2022 that will close this issue
@gmaze gmaze linked a pull request Dec 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants