Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing some tests? #271

Open
acorncom opened this issue Jun 21, 2020 · 1 comment · Fixed by #338
Open

Writing some tests? #271

acorncom opened this issue Jun 21, 2020 · 1 comment · Fixed by #338

Comments

@acorncom
Copy link
Contributor

Howdy, was looking this addon over and noticed that there aren't many tests. Think that'd be something we should add here over time?
@ttill
Copy link
Contributor

ttill commented Jun 24, 2020

Hi, thanks for bringing this up! You are right, that currently coverage is rather poor. Unfortunately I do not have the resources to add any tests right now, but I will happily accept any PR doing so.

@acorncom acorncom mentioned this issue Oct 18, 2020
Merged
@ttill ttill reopened this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guards against a set on destroyed error acorncom/ember-scanner
2 participants
@ttill @acorncom