[build-properties] Fix android build failure (#17321)

(cherry picked from commit f7e7045)
expo · May 5, 2022 · 4cb9822 · 4cb9822
1 parent 6a62fea
commit 4cb9822
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/updates-e2e.yml b/.github/workflows/updates-e2e.yml
@@ -13,6 +13,7 @@ on:
       - packages/expo-updates/**
       - packages/expo/android/**
       - packages/expo/ios/**
+      - templates/expo-template-bare-minimum/**
   push:
     branches: [main, 'sdk-*']
     paths:
@@ -25,6 +26,7 @@ on:
       - packages/expo-updates/**
       - packages/expo/android/**
       - packages/expo/ios/**
+      - templates/expo-template-bare-minimum/**
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.ref }}
@@ -115,7 +117,7 @@ jobs:
         run: sed -i -e "s/UPDATES_PORT/$UPDATES_PORT/" ./App.js
       - name: Assemble release APK
         working-directory: ../updates-e2e/android
-        run: ./gradlew assembleRelease
+        run: ./gradlew assembleRelease --stacktrace
       - name: Copy APK to working directory
         run: cp -R ../updates-e2e/android/app/build/outputs/apk artifact
       - name: Upload test APK artifact

diff --git a/templates/expo-template-bare-minimum/android/build.gradle b/templates/expo-template-bare-minimum/android/build.gradle
@@ -6,8 +6,8 @@ buildscript {
     ext {
         buildToolsVersion = findProperty('android.buildToolsVersion') ?: "31.0.0"
         minSdkVersion = 21
-        compileSdkVersion = Integer.parseInt(findProperty('android.compileSdkVersion') ?: 31)
-        targetSdkVersion = Integer.parseInt(findProperty('android.targetSdkVersion') ?: 31)
+        compileSdkVersion = Integer.parseInt(findProperty('android.compileSdkVersion') ?: "31")
+        targetSdkVersion = Integer.parseInt(findProperty('android.targetSdkVersion') ?: "31")
         if (hasProperty('android.kotlinVersion')) {
             kotlinVersion = findProperty('android.kotlinVersion')
         }