Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking a relative time PR #84

Closed
cafkafk opened this issue Jul 30, 2023 · 2 comments
Closed

Picking a relative time PR #84

cafkafk opened this issue Jul 30, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed needs feedback

Comments

@cafkafk
Copy link
Member

cafkafk commented Jul 30, 2023

2023-07-30_05-46
#6

2023-07-30_05-46_1
#44

I prefer the shorter style, but I also want it to be left-aligned.

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

#44 seems to be the better pick after reviewing the code

@cafkafk
Copy link
Member Author

cafkafk commented Jul 30, 2023

I changed #44 to be left aligned
2023-07-30_06-06

I think it looks vastly better
2023-07-30_06-07

Now, for the future, it would be great if there was future work done to align timestamps like this:

32 minutes 
10 minutes 
 1 day     
10 minutes 
32 minutes 
 1 hour    
10 minutes 
 1 hour    
10 minutes 

But that's gonna be another PR.

@cafkafk cafkafk added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 30, 2023
@cafkafk cafkafk closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed needs feedback
Projects
None yet
Development

No branches or pull requests

1 participant