Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleting output directory is hideous #7

Open
bertsky opened this issue May 8, 2024 · 0 comments
Open

deleting output directory is hideous #7

bertsky opened this issue May 8, 2024 · 0 comments

Comments

@bertsky
Copy link

bertsky commented May 8, 2024

bool refresh_outdir = true;

Because of this, I just deleted my complete home directory.

All I did was use -o ~.

This is extremely surprising for users. I could somewhat understand you want to delete the --tempdir, but the output directory? Deleting anything recursively, before even doing anything at all, with no regard for files that this program never touches?

There is a CAUTION in the help text for --tempdir:

printf("%s", "-D, --tempdir directory Temporary directory for DVD-Audio files (dvda-author)." J "Optional. CAUTION: tempdir will be erased unless --no-refresh-tempdir is used.\n\n");

But not for --output.

IMO this should not be the default behaviour.

@bertsky bertsky changed the title deleting output directory is unexpected and dangerous deleting output directory is hideous May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant