Kubernetes was relax restrictions on environment variable names.

[chenlein]

Reopen: #447
Kubernetes was relax restrictions on environment variable names.
Sample code:

          env:
            - name: "cluster.name"
              value: "elasticsearch-cluster-1550544058281"
            - name: "bootstrap.memory_lock"
              value: "true"
            - name: "discovery.zen.ping.unicast.hosts"
              value: "elasticsearch-discovery-1550544058281"
            - name: "node.master"
              value: "false"
            - name: "node.data"
              value: "true"
            - name: "ES_JAVA_OPTS"
              value: "-Xms8192m -Xmx8192m"

Error message:

javax.validation.ConstraintViolationException: Constraint Validations: name must match "^[A-Za-z_][A-Za-z0-9_]*$" on bean: EnvVar(name=cluster.name, value=elasticsearch-cluster-1550544067656, valueFrom=null, additionalProperties={})

[rohanKanojia]

@chenlein : oh, I see. Could you please raise a PR to relex these restrictions? I think you would just need to change some regexes here:

kubernetes-client/kubernetes-model/kubernetes-model-annotator/src/main/java/io/fabric8/kubernetes/annotator/KubernetesTypeAnnotator.java

Line 41 in 16baff4

private final String nameIsDNS952LabelPattern = "[a-z]([-a-z0-9]*[a-z0-9])?";

[chenlein]

@rohanKanojia : I try to fix this problem，I modified the file of you told me, see here. However I can not generate model, when I execute make, some errors have occurred：

chenleis-MacBook-Pro:kubernetes-model chenlei$ make
dep ensure -v
CGO_ENABLED=0 GO15VENDOREXPERIMENT=1 go build -a ./cmd/generate/generate.go
./generate > kubernetes-model/src/main/resources/schema/kube-schema.json
./generate validation > kubernetes-model/src/main/resources/schema/validation-schema.json
mvn clean install
[INFO] Scanning for projects...
<snip>
[INFO] Final Memory: 45M/1184M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.jsonschema2pojo:jsonschema2pojo-maven-plugin:0.4.23:generate (default) on project kubernetes-model: Execution default of goal org.jsonschema2pojo:jsonschema2pojo-maven-plugin:0.4.23:generate failed: Path not present: kubernetes_apimachinery_pkg_runtime_ImageRawExtension -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :kubernetes-model
make: *** [build] Error 1

And, my kube-schema.json are very different from yours. Just like follows：

{
  "id": "http://fabric8.io/fabric8/v2/Schema#",
  "$schema": "http://json-schema.org/schema#",
  "definitions": {
    "github_com_fabric8io_kubernetes_model_vendor_github_com_openshift_api_apps_v1_CustomDeploymentStrategyParams": {
      "type": "object",
      "description": "",
      "properties": {
        "command": {
          "type": "array",
          "description": "",
          "javaOmitEmpty": true,
          "items": {
            "type": "string",
            "description": ""
          }
        },
        "environment": {
          "type": "array",
          "description": "",
          "javaOmitEmpty": true,
          "items": {
            "$ref": "#/definitions/github_com_fabric8io_kubernetes_model_vendor_k8s_io_api_core_v1_EnvVar",
            "javaType": "EnvVar"
          }
        },
        "image": {
          "type": "string",
          "description": ""
        }
      },
      "additionalProperties": true,
      "javaType": "CustomDeploymentStrategyParams",
      "javaInterfaces": [
        "io.fabric8.kubernetes.api.model.KubernetesResource"
      ]
    },
    "github_com_fabric8io_kubernetes_model_vendor_github_com_openshift_api_apps_v1_DeploymentCause": {
      "type": "object",
<snip>

So, I can't confirm if my changes are correct.

[rohanKanojia]

@chenlein : ah, I see. Thanks for trying it out. I would try pulling your changes and build and then come back to this. Bdw, Could you please create a draft PR in the meantime so that this effort doesn't get lost?