From bc9edfa7cd7a10a0147f6536371a7fe8499490a3 Mon Sep 17 00:00:00 2001 From: Enoah Netzach Date: Tue, 17 Jan 2017 18:47:51 +0100 Subject: [PATCH] Hide `--internal-testing-template` (former `--template`) CLI option --- packages/create-react-app/index.js | 12 +++++++++--- tasks/e2e-kitchensink.sh | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/create-react-app/index.js b/packages/create-react-app/index.js index 75a2d51ab49..e1ab3ccbb4b 100644 --- a/packages/create-react-app/index.js +++ b/packages/create-react-app/index.js @@ -52,6 +52,7 @@ if (currentNodeVersion.split('.')[0] < 4) { process.exit(1); } +var commander = require('commander'); var fs = require('fs-extra'); var path = require('path'); var execSync = require('child_process').execSync; @@ -60,7 +61,7 @@ var semver = require('semver'); var projectName; -var program = require('commander') +var program = commander .version(require('./package.json').version) .arguments('') .usage(chalk.green('') + ' [options]') @@ -69,7 +70,7 @@ var program = require('commander') }) .option('--verbose', 'print additional logs') .option('--scripts-version ', 'use a non-standard version of react-scripts') - .option('--template ', 'use a non-standard application template') + .allowUnknownOption() .on('--help', function () { console.log(' Only ' + chalk.green('') + ' is required.'); console.log(); @@ -96,7 +97,12 @@ if (typeof projectName === 'undefined') { process.exit(1); } -createApp(projectName, program.verbose, program.scriptsVersion, program.template); +var hiddenProgram = new commander.Command() + .option('--internal-testing-template ', '(internal usage only, DO NOT RELY ON THIS) ' + + 'use a non-standard application template') + .parse(process.argv) + +createApp(projectName, program.verbose, program.scriptsVersion, hiddenProgram.internalTestingTemplate); function createApp(name, verbose, version, template) { var root = path.resolve(name); diff --git a/tasks/e2e-kitchensink.sh b/tasks/e2e-kitchensink.sh index a4d640894c1..eecd6ed62a7 100755 --- a/tasks/e2e-kitchensink.sh +++ b/tasks/e2e-kitchensink.sh @@ -113,7 +113,7 @@ npm install $cli_path # Install the app in a temporary location cd $temp_app_path -create_react_app --scripts-version=$scripts_path --template=$root_path/packages/react-scripts/fixtures/kitchensink test-kitchensink +create_react_app --scripts-version=$scripts_path --internal-testing-template=$root_path/packages/react-scripts/fixtures/kitchensink test-kitchensink # ****************************************************************************** # Now that we used create-react-app to create an app depending on react-scripts,