-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA features #1086
Comments
@gaearon, what you think about PWA features? It is possible? |
I'd be interested in supporting that. I just don't know enough / don't have enough time to work on this. If somebody could lead this effort and write up a proposal for how that would work I’d be thrilled! |
Here is a good PWA analyzer |
What about this project as a starting point? (As well as the before-mentioned of course.) |
Previously discussed here #192 |
I'm often getting confused about which technologies exactly are being marketed under the "PWA" umbrella. Can I ask somebody to make a comprehensive list? Is jeffposnick/create-react-pwa@starting-point...pwa "enough"? Is there anything we could enable by default there? cc @addyosmani |
Someone from this episode of JavaScript Air might be able to chime in as well https://javascriptair.com/episodes/2016-05-25 Also here's a Baseline PWA checklist |
To be a PWA (in todays terms) you need following:
This all need to make browsers display "Add to Homescreen" popup. Though, any website can be added manually to the home screen (in Chrome) even if it doesn't have anything from that list. |
@gaearon Thanks for the ping! 🔔 The current baseline we recommend for apps trying to be a PWA is that they're:
As you've noted elsewhere (e.g #1056) it looks like the loading part of this can be tackled once you've switched to Webpack 2 and use Otherwise, happy to work on a PR for c-r-a to add PWA support or ask someone on my team to. |
Once we switch over to WP2 and document |
🎉 So happy to hear that. It just went into PR phase on WP webpack/webpack#3350. |
Call for help on adding dynamic |
Webpack 2.2 released the Release Candidate |
Looks like things are underway to upgrade us to Webpack 2 (#1291). What's the status on this issue? |
If you have specific suggestions please send PRs and we'll review them! We intend to move to Webpack 2 in 0.10. |
I think i have a good sense how this could be quite easily achieved during the production build using However i'm not sure how we could best manage the It appears we are now using a webpack plugin (HtmlWebpackPlugin) to dynamically inject the bundled scripts into index.html during development. I imagine we could store in memory and serve the build artifacts from |
@ianschmitz, I'd be happy to assist with a Theoretically, it's the equivalent of jeffposnick/create-react-pwa@c-r-a-0.6.0...c-r-pwa-0.6.0, most likely using either the The best way I've found of dealing with the debug/local development scenario is to serve a no-op The main pain point that I've seen with this sort of integration in the past (c.f. It may also make sense to bake a UI pattern like displaying a "This application has been updated. Please reload." toast into the |
I had some time today to see what it would be like to add in service worker generation by modifying the webpack build inside of The changes aren't that bad: https://github.com/facebookincubator/create-react-app/compare/master...jeffposnick:pwa?expand=1 (I may not be following c-r-a best practices by including that extra What makes this nicer than I thought it would be is that Some things that would still be needed, beyond what's currently in that diff:
CC: @addyosmani |
I've made a few more additions, including documentation that I hope will help developers unfamiliar with offline-first web apps understand what's going on. https://github.com/facebookincubator/create-react-app/compare/master...jeffposnick:pwa?expand=1 is the current state of things, and I'm going to take another few days to test out some edge cases and re-read through the documentation I wrote before filing a formal PR and soliciting feedback there. |
Looking great @jeffposnick! Have we thought about how we may handle the case where the developer removes the PWA features from the index.js? Do we still want to spit out a Let me know if I can help at all with the PR! |
@ianschmitz my current thinking was to continue building the But I've added more info the README about not doing the initial registration in the first place, and additionally provided some code for uninstalling a previously installed service worker, for folks who would prefer not to make use of the service worker. I've got a "dummy" PR to solicit feedback up at jeffposnick#1 prior to filing a PR against this official repo. |
Relevant: #1728 |
Relevant #2089 |
Can I use PWA features with create-react-app, such as manifest, service workers? Where to put manifest?
The text was updated successfully, but these errors were encountered: