Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable offline Yarn support #1235

Closed
gaearon opened this issue Dec 11, 2016 · 11 comments
Closed

Enable offline Yarn support #1235

gaearon opened this issue Dec 11, 2016 · 11 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Dec 11, 2016

It appears that it doesn't work. Shall we opt in?

screen shot 2016-12-11 at 09 53 38

@sylvainbannier
Copy link

I have issues with offline support in yarn v0.17.10 yarnpkg/yarn#2162. Waiting, for triage. If this is confirmed, then I guess CRA should wait for a fix in Yarn.

@gaearon
Copy link
Contributor Author

gaearon commented Dec 11, 2016

Note that I also tried --offline and it didn't work because it requested latest whereas we only have a specific version in cache (for example 0.8.4). I wish there was a way to "agree" to use whatever local version we have if there is no network connection.

Related: yarnpkg/yarn#1277 (comment)

Possible improvement is to give user option [y/n]-prompt to use latest local version. (out of scope for this PR, should be feature request?)

@gaearon
Copy link
Contributor Author

gaearon commented Dec 12, 2016

Filed as yarnpkg/yarn#2225.

@voxsim
Copy link
Contributor

voxsim commented Jan 17, 2017

@gaearon please let me know if this works right now ;)

@gaearon
Copy link
Contributor Author

gaearon commented Jan 18, 2017

Does it require any flags?

@voxsim
Copy link
Contributor

voxsim commented Jan 20, 2017

@gaearon sorry for the late answer, but I lose some time to understand where I have to change the yarnpkg, to use what I build instead of the global package :)

Btw if you add --offline after --dev and --exact it should work from the next version!

@gaearon
Copy link
Contributor Author

gaearon commented Jan 20, 2017

Want to send a PR?

@voxsim
Copy link
Contributor

voxsim commented Jan 20, 2017

Sure

@gaearon
Copy link
Contributor Author

gaearon commented Jan 20, 2017

Thx

@voxsim
Copy link
Contributor

voxsim commented Jan 20, 2017

@gaearon I prefer to wait for the PR, because if you add --prefer-offline still don't work properly. I mean when you are online it does not switch from offline to online and other stuff, the road seems long I think you should reopen #2225. I will work on that because It could be useful for me creating react app offline ;)

Apart from this, do you think some end-to-end tests for create-react-app could be useful? Test manually the scripts every time is challenging :P

@gaearon
Copy link
Contributor Author

gaearon commented Mar 7, 2017

It's working now.

@gaearon gaearon closed this as completed Mar 7, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants