-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master crashes when opening two apps (and port conflicts) #2112
Comments
This regression was introduced when we fixed the behavior of our tl;dr we listen on |
Filed an issue upstream: node-modules/detect-port#19. |
Hmm. If we're listening on 127.0.0.1, does it mean access from local network doesn't mean by default anymore? This seems frustrating. Why did we change this? |
We've always said we're listening on localhost which implies we're not listening on the entire local network. Mainly, it was done out of interest in security (since we proxy API calls which are going to be elevated during development). Previously we said I'm not opposed to listening to |
I'd prefer we keep the existing behavior with using 0.0.0.0 as a default. I'm cool with printing 0.0.0.0 to the console in this case for posterity. |
Fair enough, the 0.9.x branch currently does this (and prints |
Opened #2117; that issue still doesn't solve this issue because Node's default behavior is to bind to IPv6, not IPv4. We might want to follow suit, but it's a bit more involved than specifying |
Um. I still don't quite get it. Can we just revert to old behavior in the meantime? Or was that fix important? |
It's important because HOST doesn't work otherwise, the issue was already fixed in detect port so we just have to update the dependency and this should start working again. |
Okay. Can you take care of this? |
Fixed via #2147 |
This is some new issue.
The text was updated successfully, but these errors were encountered: