-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quitting react dev server closes browser and any open tabs #3113
Comments
That's not desirable! |
I did notice this issue a couple months ago. The problem is that spawning the browser child process is handled by the opn module, which is very useful to abstract little details of different operative systems, but does not expose much options to detach the child process from the original process. I tried sending a pull request with a possible solution, but I didn't got a response in time so I moved on to different matters. |
This doesn't seem to happen for me:
Operating system: macOS Sierra Browser and version (if relevant): Chrome Version 63.0.3215.0 EDIT: I've since tried this on Arch Linux with |
Thanks @W1lkins for confirming the issue in the |
Hi I am having this same issue on Ubuntu 16.10 running node v6.11.1, is there a workaround until a fix is released? |
I think the easiest workaround is to have your browser up and running well before starting the dev server. If the browser is an independent process, it won't be closed when the dev server is interrupted. |
I bumped |
The fix is out in |
this issue occurring again. I'm using |
Happening for me too, using |
Unfortunately it happens for me too. I've gone from This is a bear as I have a On |
FWIW if you add wait: false to the opn options in startBrowserProcess, opn will detach the child process so it's not linked to the react scripts process. |
Still being affected by this, is there a workaround to this? |
I do not see this in Win10, Firefox, & bash in VSCode. |
This only occurs if create-react-app creates the browser process itself. See info below.
Environment
node -v
: v6.11.3npm -v
:5.4.1yarn --version
(if you use Yarn):npm ls react-scripts
(if you haven’t ejected): react-scripts@1.0.12Operating system: Ubuntu 16.04
Browser and version (if relevant): Chromium 60.0.3112.113
Steps to Reproduce
npm run start
in a repo created withcreate-react-app
Expected Behavior
The browser remains open. Or maybe gives a confirm dialog, then closes.
Actual Behavior
The browser closes, losing my open tabs.
The text was updated successfully, but these errors were encountered: