Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-scripts to use jest 22 #3636

Closed
AdrienLemaire opened this issue Dec 22, 2017 · 2 comments
Closed

Upgrade react-scripts to use jest 22 #3636

AdrienLemaire opened this issue Dec 22, 2017 · 2 comments

Comments

@AdrienLemaire
Copy link

When upgrading jest to v22, our tests (run with react-scripts) break due to react-scripts v1.0.17 still using v20, while v22 added a breaking change, upgrading JSDOM from v9 to v11.

This results in the tests breaking with error TypeError: environment.setup is not a function. (related issue raised @jest )

@gaearon
Copy link
Contributor

gaearon commented Dec 22, 2017

You can't "update Jest to v22" while using react-scripts. The point of react-scripts is to hide Jest (and a few other tools) under one umbrella. It is not, and has never been supported to try to install tools directly.

I suppose it's time we start breaking the build when people attempt that. We get too many issues like this when people break their setups.

(As for updating to 22, yes, we'll do that in the near future. We were just waiting for it to come out.)

@gaearon
Copy link
Contributor

gaearon commented Dec 22, 2017

We track Jest update in #2639.

I created a new issue for breaking the build when one attempts to update tools circumventing react-scripts: #3638.

So I think we can close this.

@gaearon gaearon closed this as completed Dec 22, 2017
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants