From 19132b193adf4b26f821555c37ed07685a496d04 Mon Sep 17 00:00:00 2001
From: Siddharth Doshi <sidoshi510@gmail.com>
Date: Fri, 17 Mar 2017 15:35:55 +0530
Subject: [PATCH 1/3] Forbid using window properties as global variables

---
 packages/eslint-config-react-app/index.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js
index b909db3e21b..bee4d061147 100644
--- a/packages/eslint-config-react-app/index.js
+++ b/packages/eslint-config-react-app/index.js
@@ -26,13 +26,21 @@ module.exports = {
   plugins: ['import', 'flowtype', 'jsx-a11y', 'react'],
 
   env: {
-    browser: true,
     commonjs: true,
     es6: true,
     jest: true,
     node: true,
   },
 
+  globals: {
+    document: true,
+    window: true,
+    confirm: true,
+    alert: true,
+    localStorage: true,
+    sessionStorage: true,
+  },
+
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',

From bac2a40b73a25dfbb325b5a3edb04b239511295e Mon Sep 17 00:00:00 2001
From: Siddharth Doshi <sidoshi510@gmail.com>
Date: Thu, 23 Mar 2017 12:24:16 +0530
Subject: [PATCH 2/3] Change globals list to match Standard.

---
 packages/eslint-config-react-app/index.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js
index bee4d061147..9144e615f19 100644
--- a/packages/eslint-config-react-app/index.js
+++ b/packages/eslint-config-react-app/index.js
@@ -35,10 +35,8 @@ module.exports = {
   globals: {
     document: true,
     window: true,
-    confirm: true,
-    alert: true,
-    localStorage: true,
-    sessionStorage: true,
+    console: true,
+    navigator: true
   },
 
   parserOptions: {

From 129baa0dcf524bec19e6f43d6de93b544766206a Mon Sep 17 00:00:00 2001
From: Joe Haddad <timer150@gmail.com>
Date: Fri, 5 May 2017 18:20:35 -0400
Subject: [PATCH 3/3] Fix globals

---
 packages/react-scripts/fixtures/kitchensink/src/App.js        | 4 ++--
 .../kitchensink/src/features/webpack/NoExtInclusion.js        | 2 +-
 .../kitchensink/src/features/webpack/UnknownExtInclusion.js   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/react-scripts/fixtures/kitchensink/src/App.js b/packages/react-scripts/fixtures/kitchensink/src/App.js
index 67de182b59e..7756f94ed4a 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/App.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/App.js
@@ -25,7 +25,7 @@ class BuiltEmitter extends Component {
   }
 
   handleReady() {
-    document.dispatchEvent(new Event('ReactFeatureDidMount'));
+    document.dispatchEvent(new window.Event('ReactFeatureDidMount'));
   }
 
   render() {
@@ -53,7 +53,7 @@ class App extends Component {
   }
 
   componentDidMount() {
-    const feature = location.hash.slice(1);
+    const feature = window.location.hash.slice(1);
     switch (feature) {
       case 'array-destructuring':
         import(
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
index 7f824c2f292..e3d4c621f51 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/NoExtInclusion.js
@@ -11,7 +11,7 @@ import React from 'react';
 import aFileWithoutExt from './assets/aFileWithoutExt';
 
 const text = aFileWithoutExt.includes('base64')
-  ? atob(aFileWithoutExt.split('base64,')[1]).trim()
+  ? window.atob(aFileWithoutExt.split('base64,')[1]).trim()
   : aFileWithoutExt;
 
 export default () => (
diff --git a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
index 70b046e9532..af88e96b637 100644
--- a/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
+++ b/packages/react-scripts/fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js
@@ -11,7 +11,7 @@ import React from 'react';
 import aFileWithExtUnknown from './assets/aFileWithExt.unknown';
 
 const text = aFileWithExtUnknown.includes('base64')
-  ? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
+  ? window.atob(aFileWithExtUnknown.split('base64,')[1]).trim()
   : aFileWithExtUnknown;
 
 export default () => (