From f33b05937b787d6d128fbbac9f2979c903f3d4fe Mon Sep 17 00:00:00 2001 From: Boris Serdiuk Date: Tue, 4 Apr 2017 23:48:31 +0200 Subject: [PATCH 1/2] Add note about installing watchman --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3a6402606db..f4010504983 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -47,6 +47,8 @@ Please also provide a **test plan**, i.e. specify how you verified that your add 2. Run `npm install` in the root `create-react-app` folder. +3. *(Only for MacOS Sierra)*: While [fix in Jest](https://github.com/facebook/jest/pull/2957) haven't released, you need to install [Watchman](https://facebook.github.io/watchman/docs/install.html), for example `brew install watchman` + Once it is done, you can modify any file locally and run `npm start`, `npm test` or `npm run build` just like in a generated project. If you want to try out the end-to-end flow with the global CLI, you can do this too: From 0bc7febc71659a9d5b61d6d4dc4dc546b38ba754 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Sat, 15 Apr 2017 00:29:35 -0400 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f4010504983..514c28ce31c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -47,7 +47,7 @@ Please also provide a **test plan**, i.e. specify how you verified that your add 2. Run `npm install` in the root `create-react-app` folder. -3. *(Only for MacOS Sierra)*: While [fix in Jest](https://github.com/facebook/jest/pull/2957) haven't released, you need to install [Watchman](https://facebook.github.io/watchman/docs/install.html), for example `brew install watchman` +3. *(Only for macOS Sierra)*: Until [0.10.0](https://github.com/facebookincubator/create-react-app/milestone/23) is released, you may need to install [Watchman](https://facebook.github.io/watchman/docs/install.html) (e.g. `brew install watchman`). Once it is done, you can modify any file locally and run `npm start`, `npm test` or `npm run build` just like in a generated project.