-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onBrokenMarkdownLinks errors for invalid links inside tilde codeblocks only #7800
Comments
Yep—we don't handle |
If I remove the broken link from the tilde codeblock than the codeblock is rendered as you would expect. This makes me think that this is not an issue with mdxjs. |
It's not—it's our own infra :) The fact that MDX accepts |
@antonk52 Thanks for reporting! #7801 should fix this. You can watch out for the next canary (should be in a few minutes) and give it a try. |
It's useful in a weird edge case, making a code block of markdown source code that contains a code block delimited by triple backtick. something like
|
In that case I would personally use four backticks... |
Have you read the Contributing Guidelines on issues?
Prerequisites
npm run clear
oryarn clear
command.rm -rf node_modules yarn.lock package-lock.json
and re-installing packages.Description
Docusaurus checks for broken links inside tilde code blocks when
onBrokenMarkdownLinks
is set tothrow
Reproducible demo
No response
Steps to reproduce
create-docusaurus
docs/intro.md
npx docusaurus build
to see the site build as expectednpx docusaurus build
to see the build fail with an errorExpected behavior
Docusaurus either does not check links inside codeblock or checks them for both backtick and tilde codeblocks when
onBrokenMarkdownLinks
is set tothrow
Actual behavior
Docusaurus errors for broken markdown links only inside tilde codeblocks when
onBrokenMarkdownLinks
is set tothrow
Your environment
Self-service
The text was updated successfully, but these errors were encountered: