Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Future task] Remove @react-native/metro-config warning from react-native start #1018

Open
huntie opened this issue Jun 29, 2023 · 0 comments
Assignees

Comments

@huntie
Copy link
Member

huntie commented Jun 29, 2023

Context

In React Native 0.73, we're shipping a prominent warning in the CLI when we can't detect that the user's Metro config extends @react-native/metro-config, which contains the base Metro config to work with React Native.

image

In the vast majority of projects, not extending @react-native/metro-config will lead to a failure to build, often with unclear errors. Therefore we are strongly recommending extending it even for highly custom setups.

However, we anticipate there will advanced users that fully define a compatible Metro config without the base package. For these users, this warning will be redundant. We anticipate that this will be a small enough user subset that we are not providing an official opt-out — however we are committing to removing this warning in general.

This task

Once we have very high confidence that all users have migrated to the new config setup, we will drop the CLI warning.

Potential related tasks:

  • To help with issue intake once we've removed this warning, we could add metadata on whether the base config is loaded, and at what version, via react-native doctor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant