Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"not implemented" error when upgrading react-native from 0.57.8 to 0.59.8 or 0.59.9 #25187

Closed
kaisontan opened this issue Jun 7, 2019 · 4 comments
Labels
Bug Resolution: Locked This issue was locked by the bot.

Comments

@kaisontan
Copy link

Hi, I was upgrading my react-native Android app from v0.57.8 to v0.59.9. However, after upgrading, my app can not start and stuck at the "not implemented" error as shown below:
Screenshot_20190607-172608_DBOS UAT

I try to downgrade to v0.59.8 but still hit the same error. After an investigation, I found out the issues is properly due to importing, I tried to comment out some import and my app can start. I have cross check all the imports was fine, but have no idea why hit "not implemented" error.

In addition, since in v0.59.0, there are changes in Metro, where a new file metro.config.js was added for inline requires features as below:
image

I tried to set the inlineRequired to true. My app can start at first, but click on a button will cause "not implemented" error to pop up again. So, I suspect the error is caused by Importing/Require in the new Metro. I also tried to build production version and it crashed when open.

Any idea what is the cause for this issue? Thank you for your help.

React Native version:
image

Steps To Reproduce

  1. upgrade to react-native to v0.59.9 from v0.57.8.

Describe what you expected to happen:

  1. The app should start normally.
@kaisontan kaisontan added the Bug label Jun 7, 2019
@kelset
Copy link
Contributor

kelset commented Jun 7, 2019

Hello there 👋 this issue seems to be related to your experience upgrading between versions. We know this has been a long lasting pain for the community so starting v0.59 we have introduced a new flow via the new CLI.

I'd suggest you use rn-diff-repo to double check that you did all the necessary steps/changes while upgrading.

Also, maybe it's just a matter of some cache not being cleaned properly? Try running:

rm -rf node_modules;
rm -rf $TMPDIR/react-native-packager-cache-*;
rm -rf $TMPDIR/metro-*;
rm -rf $TMPDIR/react-*;
rm -rf $TMPDIR/haste-*;
watchman watch-del-all;
yarn;
yarn start --reset-cache; (for starting the bundler)

Given that this is not strictly a bug with the library itself I'll close this, but if you can create a repro that has this issue with a freshly created react-native init project we can reopen it and investigate it further 🤗

@kelset kelset closed this as completed Jun 7, 2019
@markowork
Copy link

@kaisontan did you fix this, I have the same issue :/

@kaisontan
Copy link
Author

Hi, @markowork . Yes, I managed to solved this.

I found out the issues is due to importing of module 'url-search-params' in one of my file. I solved by removing the import, install another package and override global polyfill.

image

image

You can read more from this post:
#23922

Hope this help you.

@markowork
Copy link

Thank you @kaisontan, it did!

@facebook facebook locked as resolved and limited conversation to collaborators Jun 7, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants