From d925a8d0be69595bab9f7c8698df39ab68b68750 Mon Sep 17 00:00:00 2001 From: Josh Story Date: Mon, 24 Oct 2022 16:32:33 -0700 Subject: [PATCH] Flight client error stack (#25560) restore error message into stack for flight prod errors --- packages/react-client/src/ReactFlightClient.js | 2 +- packages/react-client/src/__tests__/ReactFlight-test.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-client/src/ReactFlightClient.js b/packages/react-client/src/ReactFlightClient.js index 6531f0c7be888..c023a1feca632 100644 --- a/packages/react-client/src/ReactFlightClient.js +++ b/packages/react-client/src/ReactFlightClient.js @@ -646,7 +646,7 @@ export function resolveErrorProd( ' builds to avoid leaking sensitive details. A digest property is included on this error instance which' + ' may provide additional details about the nature of the error.', ); - error.stack = ''; + error.stack = 'Error: ' + error.message; (error: any).digest = digest; const errorWithDigest: ErrorWithDigest = (error: any); const chunks = response._chunks; diff --git a/packages/react-client/src/__tests__/ReactFlight-test.js b/packages/react-client/src/__tests__/ReactFlight-test.js index e974ceb3d6d09..6760531f75839 100644 --- a/packages/react-client/src/__tests__/ReactFlight-test.js +++ b/packages/react-client/src/__tests__/ReactFlight-test.js @@ -57,6 +57,9 @@ describe('ReactFlight', () => { ' may provide additional details about the nature of the error.', ); expect(this.state.error.digest).toContain(this.props.expectedMessage); + expect(this.state.error.stack).toBe( + 'Error: ' + this.state.error.message, + ); } } render() {