-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write documentation for react-test-renderer
#7431
Comments
I'm hitting the While we're talking react-test-render docs, it may be obvious, but you can't use react-test-renderer with React 0.14 code due to module dependencies, this is more of a Jest documentation bug. jestjs/jest#1364 |
Please see my replies: |
The inject bug is slightly more complicated than #7386 (comment), @gaearon -- I've turned off auto-mocking entirely, and it still happens. Here's some more detail on what's been done/suggested: jestjs/jest#1353 (comment) |
Sorry I wasn’t clear. I’m saying the solution to this is to mock |
Let's track this in #8060. |
This is the first day I've used
react-test-renderer
, and I've already stumbled upon three problems:injectEnvironment
called twice:react-test-renderer
andreact-dom
#7386null
when rendered withreact-test-renderer
ReactTestRenderer doesn't work with refs or ReactDOM.findDOMNode #7371react-test-renderer
is going to be shipped withcreate-react-app
very soon (?) (it's inreact-test-renderer@0.3.0-alpha
), so I think it deserves some more comprehensive documentation as soon as possible. With at least some troubleshooting bulletpoints and some text about how one are supposed to do with refs.I sometimes use refs from
componentDidMount
. For example for setting focus on an inputthis.refs.input.focus()
. But such code will fail withcannot call focus() on undefined
. Should we always test if a ref isn't undefined before using them? Or do you have some plans forreact-test-renderer
in near future that will solve this issue in some way?The text was updated successfully, but these errors were encountered: