{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":241722462,"defaultBranch":"main","name":"below","ownerLogin":"facebookincubator","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-02-19T20:47:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/19538647?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717749863.0","currentOid":""},"activityList":{"items":[{"before":"f19be5c6e2940a6feb3a4dec63a48401eee0afc8","after":"b3f62f8b65284974da04d293a7eaa01709500048","ref":"refs/heads/main","pushedAt":"2024-09-12T17:20:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable `futures` feature on `indicatif`\n\nSummary: This adds the super useful `wrap_stream` to progress bars, which make creating progress bars for things like \"execute this query for each item in this vector and do a progress bar while you're doing it\" *way* easier to express. There's an argument here about dependency creep, but we do already have `rayon` enabled on `indicatif`.\n\nReviewed By: edward-shen\n\nDifferential Revision: D62575936\n\nfbshipit-source-id: 33c1f500a6fd253059271d40255084eea53a03a7","shortMessageHtmlLink":"Enable futures feature on indicatif"}},{"before":"89ff3ba5c913382d7a11f9758f5deade1a660b21","after":"f19be5c6e2940a6feb3a4dec63a48401eee0afc8","ref":"refs/heads/main","pushedAt":"2024-08-30T21:32:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrade bitflags\n\nSummary: I need these newer versions in a package I want. Upgrade them so instead of having two copies floating around the repo (one we use, one as a dependency), we only have one.\n\nReviewed By: zertosh\n\nDifferential Revision: D62025056\n\nfbshipit-source-id: 452d440cfa3b22f57f113568774c39fcb2fe2446","shortMessageHtmlLink":"Upgrade bitflags"}},{"before":"2e09615a57ce738bd0981e94e67fce2058456616","after":"89ff3ba5c913382d7a11f9758f5deade1a660b21","ref":"refs/heads/main","pushedAt":"2024-08-28T00:40:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump anyhow to 1.0.86\n\nReviewed By: fanzeyi, dtolnay\n\nDifferential Revision: D61876827\n\nfbshipit-source-id: 54223a5741114f76152c981ef2bce472970aa8a9","shortMessageHtmlLink":"Bump anyhow to 1.0.86"}},{"before":"54a05cbc6ee8e14533dfd2426733490535fb0a66","after":"2e09615a57ce738bd0981e94e67fce2058456616","ref":"refs/heads/main","pushedAt":"2024-08-27T19:12:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update `libbpf-rs` & `libbpf-cargo` to `0.24.4`\n\nSummary:\nUpdate `libbpf-rs` and `libbpf-cargo` to `0.24.4`. On the `libbpf-rs`\nside, this version adds the `Program::fd_from_pinned_path` API. For\n`libbpf-cargo`, we worked around a potential forward incompatibility\nissue when a old system `libbpf` is being used (as opposed to a vendored\ncopy).\n\nReviewed By: dtolnay\n\nDifferential Revision: D61864698\n\nfbshipit-source-id: 699a1a3134ef71dda374c81b4784a00596449e6b","shortMessageHtmlLink":"Update libbpf-rs & libbpf-cargo to 0.24.4"}},{"before":"ecc72b45653034aeaefa4cfa0a35fbcfd4bbf4d9","after":"54a05cbc6ee8e14533dfd2426733490535fb0a66","ref":"refs/heads/main","pushedAt":"2024-08-23T20:12:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update `libbpf-rs` & `libbpf-cargo` to 0.24.2\n\nSummary:\nUpdate libbpf-rs and libbpf-cargo to 0.24.3. This version includes the\nmeans for suppressing potential clippy warnings when generating a\nskeleton based on a BPF object file that does not actually contain any\nmaps.\n\nReviewed By: capickett\n\nDifferential Revision: D61725645\n\nfbshipit-source-id: 24477e2d010b7a6e2b9d131e542d3bb62e67dc1c","shortMessageHtmlLink":"Update libbpf-rs & libbpf-cargo to 0.24.2"}},{"before":"7655709e1e606b37456bcc03ef7de63aeb2c98b5","after":"ecc72b45653034aeaefa4cfa0a35fbcfd4bbf4d9","ref":"refs/heads/main","pushedAt":"2024-08-15T17:15:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update `libbpf-rs` & `libbpf-cargo` to 0.24.2\n\nSummary:\nUpdate `libbpf-rs` and `libbpf-cargo` to 0.24.2. This version includes a\nfix for a panic encountered when opening a skeleton containing a kconfig\nmap.\n\nReviewed By: ukautz\n\nDifferential Revision: D61340346\n\nfbshipit-source-id: 978449e991566a76d11732a9428e9a7f57713b84","shortMessageHtmlLink":"Update libbpf-rs & libbpf-cargo to 0.24.2"}},{"before":"70187b05f66b4633a3350d46d57b3343683ce49c","after":"7655709e1e606b37456bcc03ef7de63aeb2c98b5","ref":"refs/heads/main","pushedAt":"2024-08-12T16:49:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update `libbpf-rs` & `libbpf-cargo` to 0.24.1\n\nSummary:\nUpdate the libbpf-rs and libbpf-cargo crates to get the latest and greatest. The\nmain changes are:\n- generated skeletons now contain publicly accessible BPF map and program\n members instead of requiring method calls\n- SkelBuilder::open() method now requires storage space for the BPF object to be\n provided\n - this change requires some code massaging in some locations\n\nReviewed By: cfsmp3\n\nDifferential Revision: D59782621\n\nfbshipit-source-id: e8d978469dbf665d26f9c8adcb7f4eb929dbaf1b","shortMessageHtmlLink":"Update libbpf-rs & libbpf-cargo to 0.24.1"}},{"before":"f3479a59703db4254feb51cb05dddfb4af8bd2bd","after":"70187b05f66b4633a3350d46d57b3343683ce49c","ref":"refs/heads/main","pushedAt":"2024-08-01T09:57:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump clap{,_complete} to 4.5.11\n\nSummary: Changelogs were boring.\n\nReviewed By: capickett\n\nDifferential Revision: D60521070\n\nfbshipit-source-id: e3061daf7f1c2ad57526c14fb79f0b569c1c563b","shortMessageHtmlLink":"Bump clap{,_complete} to 4.5.11"}},{"before":"b0e79f40662216b925215cd288aa1cf5a4e624d8","after":"f3479a59703db4254feb51cb05dddfb4af8bd2bd","ref":"refs/heads/main","pushedAt":"2024-07-26T18:39:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add init guard\n\nReviewed By: brianc118\n\nDifferential Revision: D60259109\n\nfbshipit-source-id: 3bd08633e81b88a59a29945e81a42d7cacd93c3e","shortMessageHtmlLink":"Add init guard"}},{"before":"df308ac8410ae05906480750678b19235c327230","after":"b0e79f40662216b925215cd288aa1cf5a4e624d8","ref":"refs/heads/main","pushedAt":"2024-07-15T21:46:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Change `flows_per_sec` to flows in `tc` module (#8237)\n\nSummary:\n`flows` is a static value. As mentioned in [man page](https://man7.org/linux/man-pages/man8/tc-fq_codel.8.html):\n\n> **flows**\n is the number of flows into which the incoming packets are\n classified. Due to the stochastic nature of hashing, multiple\n flows may end up being hashed into the same slot. Newer flows\n have priority over older ones. This parameter can be set only at\n load time since memory has to be allocated for the hash table.\n Default value is 1024.\n\nThus, converting this to a rate will always give zero. Change `flows_per_sec` to `flows` which is basically the last collected value.\n\nPull Request resolved: https://github.com/facebookincubator/below/pull/8237\n\nReviewed By: antonis-m\n\nDifferential Revision: D59769678\n\nPulled By: brianc118\n\nfbshipit-source-id: 6a4fafbef35e48e95acf3dc31c0d8acc971b7a1e","shortMessageHtmlLink":"Change flows_per_sec to flows in tc module (#8237)"}},{"before":"d20b98575801e6137e8a8d456e8a0294235af3de","after":"df308ac8410ae05906480750678b19235c327230","ref":"refs/heads/main","pushedAt":"2024-07-03T17:04:19.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"clippy lints (#8236)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/below/pull/8236\n\nReviewed By: boyuni\n\nDifferential Revision: D59021487\n\nfbshipit-source-id: f839bb2503f79961f591bd463bf649d88aa04f6f","shortMessageHtmlLink":"clippy lints (#8236)"}},{"before":"839bc3a46c39283e9f6d5cfc03f6a2c4a827f42d","after":"d20b98575801e6137e8a8d456e8a0294235af3de","ref":"refs/heads/main","pushedAt":"2024-06-17T22:55:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update `libbpf-rs` & `libbpf-cargo` to `0.23.3`\n\nSummary:\nUpdate the libbpf-rs and libbpf-cargo crates to version 0.23.3 to get the\nlatest and greatest.\n\nReviewed By: jsgf\n\nDifferential Revision: D58436494\n\nfbshipit-source-id: b5a9f2ae58fdf65d843db79271ae37ec53c8a815","shortMessageHtmlLink":"Update libbpf-rs & libbpf-cargo to 0.23.3"}},{"before":"bc425da870a2daa574977aa4f4ee329b7cdcd71f","after":"839bc3a46c39283e9f6d5cfc03f6a2c4a827f42d","ref":"refs/heads/main","pushedAt":"2024-06-17T14:35:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support resolved macros in named deps in autocargo\n\nSummary: This diff implements support for dynamically computed `named_deps` crate names in autocargo using the same mechanism that was used to support them in rust-analyzer in D58638036. Buck2 exposes a `…[named_deps]` subtarget which is a file containing the actual name of all the named deps, and when producing autocargo's JSON input from fbcode_macros we can read this and update the `named_deps` dictionary entry with the real crate name, similar to how we already update `crate` in a similar way by reading the value of `crate_dynamic` from a file.\n\nReviewed By: zertosh\n\nDifferential Revision: D58656554\n\nfbshipit-source-id: 1e3de91852b1aad8d0212295b729099c6eedf984","shortMessageHtmlLink":"Support resolved macros in named deps in autocargo"}},{"before":"8eaed8ad4f323a78cb88e6ef992e43b62c7a9699","after":"bc425da870a2daa574977aa4f4ee329b7cdcd71f","ref":"refs/heads/main","pushedAt":"2024-06-11T00:49:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Dodge collisions with _arguments options\n\nSummary:\n*Repinning after getting an upstream PR approved.*\n\n## Problem\nThe zsh completions generated by clap_completes use an unsafe calling syntax for the `_arguments` helper function that results in an error condition when certain arguments are defined by the application using clap and clap_complete.\n\nSpecifically, the following error after typing \"foo \" then hitting tab\n```\n% foo\n_describe:compadd:114: unknown match specification character `+'\n_describe:compadd:114: unknown match specification character `+'\n_describe:compadd:114: unknown match specification character `+'\n_describe:compadd:134: unknown match specification character `+'\n_arguments:compadd:551: unknown match specification character `+'\n```\nresults from attempting to define a `-M` argument with the following command in a completion function.\n```\n_foo() { _arguments '-M+:nonce' '--help' }\ncompdef _foo foo\n```\nThe plus character is a standard modifier for zsh arguments defined in the [zsh completion spec](https://zsh.sourceforge.io/Doc/Release/Completion-System.html#Completion-Functions). Similar errors are seen with other optspec strings as well.\n\nNote that the other arguments defined for the `_arguments` function misbehave as well, mostly resulting in unexpected behavioral changes to completion and missing completions.\n\n## Solution\nPer the documentation, the `_arguments` function uses a single colon (`:`) argument as a separator between its own arguments and the arguments it is being used to define. Thus, the problem can be avoided with this completion function:\n```\n_bar() { _arguments : '-M+:nonce' '--help' }\ncompdef _bar bar\n```\nwhich results in the following response after typing \"bar \" then hitting TAB TAB. (The first tab completes the leading hyphen. The second shows options.)\n```\n% bar -\n--help -M+\n```\n\nReviewed By: ndmitchell\n\nDifferential Revision: D58034650\n\nfbshipit-source-id: 5093dc06f2b6238d48e861544c749937b020b48b","shortMessageHtmlLink":"Dodge collisions with _arguments options"}},{"before":"7eb27be07322af329680094ac44be4c5773f0ba3","after":"8eaed8ad4f323a78cb88e6ef992e43b62c7a9699","ref":"refs/heads/main","pushedAt":"2024-06-10T22:06:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: cmdline: Avoid MPSC queue overhead in priority inversion avoidance\n\nSummary:\nmpsc channels manage a queue of messages that they receive from multiple\nproducers. This queue management involves additional synchronisation\noverhead to ensure that messages are correctly enqueued and dequeued\nwith proper consistency. In our case, we only have one producer and one\nconsumer, so the complexity and overhead of managing multiple producers\nis unnecessary, and we can just rely on a cheap Mutex for\nsynchronisation.\n\nThis saves about 0.5-1% of CPU instructions per iteration due to the\nreduction in synchronization overhead associated with the \"m\" part of\nthe mpsc channel.\n\nReviewed By: brianc118\n\nDifferential Revision: D58316866\n\nfbshipit-source-id: 2cdbe78f845f68b3f8547abef7e22ef5eee88d8e","shortMessageHtmlLink":"below: cmdline: Avoid MPSC queue overhead in priority inversion avoid…"}},{"before":"6b03cd67ca309b83e7abbb71b7cd9f620984d1ff","after":"7eb27be07322af329680094ac44be4c5773f0ba3","ref":"refs/heads/main","pushedAt":"2024-06-10T18:42:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: exitstat: Read MM_{ANON,SHMEM}PAGES per-CPU counters for v6.2\n\nSummary:\nIt looks like when this code was refactored for the mm_struct\nchanges MM_FILEPAGES was unintentionally used for all counters -- these\nshould be MM_ANONPAGES and MM_SHMEMPAGES.\n\nReviewed By: brianc118\n\nDifferential Revision: D58358989\n\nfbshipit-source-id: 945d7fdf4dfd9f48120b504e9848d1ce41fe32dd","shortMessageHtmlLink":"below: exitstat: Read MM_{ANON,SHMEM}PAGES per-CPU counters for v6.2"}},{"before":"bcc9f0a1a3b2696b9f393a8d70ab66dc5b172ff0","after":"6b03cd67ca309b83e7abbb71b7cd9f620984d1ff","ref":"refs/heads/main","pushedAt":"2024-06-10T18:35:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: treewide: .split_whitespace() -> .split_ascii_whitespace()\n\nSummary:\nThis results in a reduction of 1-2% of CPU instructions per iteration because\nit doesn't require checking all kinds of Unicode graphemes.\n\nReviewed By: lnyng\n\nDifferential Revision: D58341393\n\nfbshipit-source-id: 9323fe0ffbd37e8d404287940373c3aa22c7cada","shortMessageHtmlLink":"below: treewide: .split_whitespace() -> .split_ascii_whitespace()"}},{"before":"59de6207d5ec6b6b88be29eb9d43069f236e7813","after":"bcc9f0a1a3b2696b9f393a8d70ab66dc5b172ff0","ref":"refs/heads/main","pushedAt":"2024-06-10T16:58:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update clap to 4.5.6 and clap_complete to 4.5.4\n\nSummary: Upgrading clap to new version (released yesterday). My motivation for doing it now is that my PR https://github.com/clap-rs/clap/pull/5476 has been released as part of this release, which should fix autocompletion for all CLIs using `visible_alias` option.\n\nReviewed By: ukautz\n\nDifferential Revision: D58283249\n\nfbshipit-source-id: 4a48e86c47519431913c34880a132049b5522e7b","shortMessageHtmlLink":"Update clap to 4.5.6 and clap_complete to 4.5.4"}},{"before":"6abb3dcb73437aeeff5b1fb471bb37115c91798a","after":"59de6207d5ec6b6b88be29eb9d43069f236e7813","ref":"refs/heads/main","pushedAt":"2024-06-10T16:32:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: main: Log panics to all log sources\n\nSummary:\nIf a user has a panic in live view, the program just exits with nothing\non stderr, which is extremely confusing.\n\nWe already set all log targets like this on Err values from the command,\nit makes sense to do it for even more egregious cases as well.\n\nReviewed By: lnyng\n\nDifferential Revision: D58357648\n\nfbshipit-source-id: 34ccdbce35fd71ce602a838678f238d9261e7920","shortMessageHtmlLink":"below: main: Log panics to all log sources"}},{"before":"6341177d9eed6210c361e6dfce4305135b9c369b","after":"6abb3dcb73437aeeff5b1fb471bb37115c91798a","ref":"refs/heads/main","pushedAt":"2024-06-07T17:44:03.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: cgroupfs: Provide buffer for CgroupReader lifetime\n\nSummary:\nThis saves a lot of CPU when the cgroup hierarchy is dense. In some\ncases with large cgroup hierarchies I have seen up to 3-4% CPU win.\n\nReviewed By: lnyng\n\nDifferential Revision: D58238969\n\nfbshipit-source-id: d7a5c2979de5df798854560277b8d9de9c0b4808","shortMessageHtmlLink":"below: cgroupfs: Provide buffer for CgroupReader lifetime"}},{"before":"1097e9a196b5dd4b4ade41ce408f82ec6d9c763e","after":null,"ref":"refs/heads/cdown/2024-06-06/main_fmt_interv","pushedAt":"2024-06-07T08:44:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"}},{"before":"e4998dccf246f35d3c8a5e162b0a46b78859d5f5","after":null,"ref":"refs/heads/cdown/2024-06-06/cgroupfs_import","pushedAt":"2024-06-07T08:44:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"}},{"before":"d3eec44cd0d0ef975f290e4381fad474964cd12f","after":null,"ref":"refs/heads/cdown/2024-06-06/refmut","pushedAt":"2024-06-07T08:44:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"}},{"before":null,"after":"d3eec44cd0d0ef975f290e4381fad474964cd12f","ref":"refs/heads/cdown/2024-06-06/refmut","pushedAt":"2024-06-06T16:55:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"},"commit":{"message":"whee","shortMessageHtmlLink":"whee"}},{"before":null,"after":"e4998dccf246f35d3c8a5e162b0a46b78859d5f5","ref":"refs/heads/cdown/2024-06-06/cgroupfs_import","pushedAt":"2024-06-06T14:00:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"},"commit":{"message":"below: cgroupfs: Convert to use internal buffer\n\nThis saves a lot of CPU when the cgroup hierarchy is dense. In some\ncases with large cgroup hierarchies I have seen up to 3-4% CPU win.","shortMessageHtmlLink":"below: cgroupfs: Convert to use internal buffer"}},{"before":"5fd84641a588694ebf663076600efb87a3f6f1dd","after":"1097e9a196b5dd4b4ade41ce408f82ec6d9c763e","ref":"refs/heads/cdown/2024-06-06/main_fmt_interv","pushedAt":"2024-06-06T08:38:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"},"commit":{"message":"below: cgroupfs: Convert to use internal buffer","shortMessageHtmlLink":"below: cgroupfs: Convert to use internal buffer"}},{"before":"8ffd100c4bc8eff242c96a64f96f737e1dc68063","after":"5fd84641a588694ebf663076600efb87a3f6f1dd","ref":"refs/heads/cdown/2024-06-06/main_fmt_interv","pushedAt":"2024-06-06T08:36:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"},"commit":{"message":"below: cgroupfs: Convert to use internal buffer","shortMessageHtmlLink":"below: cgroupfs: Convert to use internal buffer"}},{"before":null,"after":"8ffd100c4bc8eff242c96a64f96f737e1dc68063","ref":"refs/heads/cdown/2024-06-06/main_fmt_interv","pushedAt":"2024-06-06T08:24:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cdown","name":"Chris Down","path":"/cdown","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/660663?s=80&v=4"},"commit":{"message":"below: cgroupfs: Convert to use internal buffer","shortMessageHtmlLink":"below: cgroupfs: Convert to use internal buffer"}},{"before":"04c38fa645e4a24e3d079ad839306f80355781f4","after":"6341177d9eed6210c361e6dfce4305135b9c369b","ref":"refs/heads/main","pushedAt":"2024-06-05T23:26:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: read_all_pids: Use byte iteration for pid walking\n\nSummary:\ncore::str::pattern::CharSearcher::next_match is very expensive (~2.5% CPU\ninstructions per iteration). This can be made much more efficient by using byte\niteration, and by avoiding having to check whether this is a pid dir twice.\n\nThis is more efficient for a few reasons:\n\n1. We do not require a check that the filename is valid UTF-8\n2. We do not require allocations (as .to_string_lossy() may)\n3. We now avoid doing the work twice\n\nRudimentary testing with a small pid hierarchy shows around a 0.5% to 1%\nreduction in CPU instructions per iteration.\n\nReviewed By: lnyng\n\nDifferential Revision: D58193111\n\nfbshipit-source-id: cba2b6f72995fe38e0ba4e055e884c069392c01e","shortMessageHtmlLink":"below: read_all_pids: Use byte iteration for pid walking"}},{"before":"27848c22dc471c9a4e196f2dd84d846c33f59685","after":"04c38fa645e4a24e3d079ad839306f80355781f4","ref":"refs/heads/main","pushedAt":"2024-06-05T20:00:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"below: ioctl: Ensure ioctl(SIOCETHTOOL) compat across libc implementations\n\nSummary:\nDifferent libc implementations (e.g., musl and glibc) define the `ioctl`\nrequest argument with different types (`c_int` for musl and `c_ulong` for\nglibc). In C, this difference is masked by typeless #defines, but in Rust, it\ncauses a type mismatch that must be explicitly handled:\n\n error[E0308]: mismatched types\n --> below/ethtool/src/reader.rs:36:58\n |\n 36 | let exit_code = unsafe { libc::ioctl(fd.as_raw_fd(), nix::libc::SIOCETHTOOL, &ifr) };\n | ----------- ^^^^^^^^^^^^^^^^^^^^^^ expected `i32`, found `u64`\n | |\n | arguments to this function are incorrect\n\nTo ensure portability and prevent type errors, we now convert\n`libc::SIOCETHTOOL` to the appropriate type. This conversion ensures that our\ncode remains compatible with both musl and glibc.\n\nReviewed By: dschatzberg\n\nDifferential Revision: D58168265\n\nfbshipit-source-id: d19789150d73dbe8fb0351cdfd4a02d79ea01400","shortMessageHtmlLink":"below: ioctl: Ensure ioctl(SIOCETHTOOL) compat across libc implementa…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMlQxNzoyMDoxMi4wMDAwMDBazwAAAAS0qbaI","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMlQxNzoyMDoxMi4wMDAwMDBazwAAAAS0qbaI","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0wNVQyMDowMDoyNy4wMDAwMDBazwAAAARdgvzT"}},"title":"Activity · facebookincubator/below"}