Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASGI mount #1950

Open
dantownsend opened this issue Aug 14, 2021 · 1 comment
Open

ASGI mount #1950

dantownsend opened this issue Aug 14, 2021 · 1 comment

Comments

@dantownsend
Copy link

Hi, I'm really glad to see Falcon supporting ASGI - great job!

In some other ASGI frameworks (for example FastAPI, Starlette and BlackSheep) there is the ability to mount other ASGI apps at a certain route. For example:

asgi_app = falcon.asgi.App()
asgi_app.mount('/admin/', some_other_asgi_app)

It's nice because you can include third party ASGI apps within your own app - in my case it's Piccolo admin. It also lets you compose your app in interesting ways, by making it consist of smaller sub apps.

I wonder if you'd consider this in a future version of Falcon? Or if it's currently possible, and I'm unaware.

If you feel it's out of scope, please feel free to close this issue. Thanks.

@vytas7
Copy link
Member

vytas7 commented Aug 15, 2021

Hi @dantownsend !
Yes, we have already been discussing the ability to mount other WSGI/ASGI apps, partially to address a common feature request to emulate "blueprints" with Falcon's own apps, as well as mounting any generic app.

See also the routing discussion: #1818, as well as #1894.

I don't think we have a dedicated issue for this feature, so yours could serve as a starting point for the ASGI flavour 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants