From 6b5272e32edb6b2799b90e6ede4998cbc8f1b618 Mon Sep 17 00:00:00 2001
From: fanmin shi <fanmin.shi@coreos.com>
Date: Fri, 5 May 2017 16:34:22 -0700
Subject: [PATCH] backend: add prometheus metric for large snapshot duration.

FIXES #7878
---
 mvcc/backend/backend.go |  1 +
 mvcc/backend/metrics.go | 10 ++++++++++
 2 files changed, 11 insertions(+)

diff --git a/mvcc/backend/backend.go b/mvcc/backend/backend.go
index a94cd65a70b3..30cb76a0c368 100644
--- a/mvcc/backend/backend.go
+++ b/mvcc/backend/backend.go
@@ -176,6 +176,7 @@ func (b *backend) Snapshot() Snapshot {
 			case <-ticker.C:
 				plog.Warningf("snapshotting is taking more than %v seconds to finish [started at %v]", time.Since(start).Seconds(), start)
 			case <-stopc:
+				snapShotDurations.Observe(time.Since(start).Seconds())
 				return
 			}
 		}
diff --git a/mvcc/backend/metrics.go b/mvcc/backend/metrics.go
index 34a56a91956f..0f2ee64cad3c 100644
--- a/mvcc/backend/metrics.go
+++ b/mvcc/backend/metrics.go
@@ -24,8 +24,18 @@ var (
 		Help:      "The latency distributions of commit called by backend.",
 		Buckets:   prometheus.ExponentialBuckets(0.001, 2, 14),
 	})
+
+	snapShotDurations = prometheus.NewHistogram(prometheus.HistogramOpts{
+		Namespace: "etcd",
+		Subsystem: "disk",
+		Name:      "backend_snapshot_duration_seconds",
+		Help:      "The latency distributions of Snapshot called by backend.",
+		// 1 second -> 512 seconds
+		Buckets: prometheus.ExponentialBuckets(1, 2, 10),
+	})
 )
 
 func init() {
 	prometheus.MustRegister(commitDurations)
+	prometheus.MustRegister(snapShotDurations)
 }