From a2e8fec6f45118609cdfbd79b855152c47e42576 Mon Sep 17 00:00:00 2001 From: Hiroyuki Komatsu Date: Mon, 20 May 2024 01:52:13 +0000 Subject: [PATCH 1/2] =?UTF-8?q?Add=20regression=20test=20for=20"=E3=81=9F?= =?UTF-8?q?=E3=81=84=E3=81=98=E3=82=93=E3=81=99=E3=81=8D=E3=82=8B"=20(?= =?UTF-8?q?=E5=AF=BE=E4=BA=BA=E3=82=B9=E3=82=AD=E3=83=AB)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PiperOrigin-RevId: 635310207 --- src/data/dictionary_oss/evaluation.tsv | 1 + src/data/test/quality_regression_test/regression.tsv | 1 + 2 files changed, 2 insertions(+) diff --git a/src/data/dictionary_oss/evaluation.tsv b/src/data/dictionary_oss/evaluation.tsv index 41f583d17..e6e7068c1 100644 --- a/src/data/dictionary_oss/evaluation.tsv +++ b/src/data/dictionary_oss/evaluation.tsv @@ -327,3 +327,4 @@ FAILED: いかなければ いかなければ Conversion Expected 行かなけ OK: すき 好き Conversion Expected 12 隙 2.28.5050 FAILED: おおすにいく 大洲に行く Conversion Expected 大須に行く 2.28.5085 FAILED: たいじんかんけい 大人関係 Conversion Expected 対人関係 2.30.5448 +FAILED: たいじんすきる 大人スキル Conversion Expected 対人スキル 2.30.5448 diff --git a/src/data/test/quality_regression_test/regression.tsv b/src/data/test/quality_regression_test/regression.tsv index c771215df..add2df080 100644 --- a/src/data/test/quality_regression_test/regression.tsv +++ b/src/data/test/quality_regression_test/regression.tsv @@ -32,3 +32,4 @@ regression いかなければ 行かなければ Conversion Expected regression すき 隙 Conversion Expected 12 regression おおすにいく 大須に行く Conversion Expected regression たいじんかんけい 対人関係 Conversion Expected +regression たいじんすきる 対人スキル Conversion Expected From 4c50a19a839228e6ea2f38c0402b4e0854df2b95 Mon Sep 17 00:00:00 2001 From: Hiroyuki Komatsu Date: Mon, 20 May 2024 08:00:07 +0000 Subject: [PATCH 2/2] Update the rule for apple_frameworks:ObjectiveC. * This will fix the build failure of OSS build for macOS. * https://github.com/google/mozc/actions/runs/9146538985/job/25146854549 * Follow-up to cl/634993024 PiperOrigin-RevId: 635325287 --- src/renderer/BUILD.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/BUILD.bazel b/src/renderer/BUILD.bazel index dcc204e11..027b93c0a 100644 --- a/src/renderer/BUILD.bazel +++ b/src/renderer/BUILD.bazel @@ -291,6 +291,7 @@ mozc_objc_library( sdk_frameworks = [ "Carbon", "Cocoa", + "ObjectiveC", ], deps = [ ":renderer_interface", @@ -307,7 +308,6 @@ mozc_objc_library( "//protocol:candidates_cc_proto", "//protocol:commands_cc_proto", "//protocol:renderer_cc_proto", - "//third_party/apple_frameworks:ObjectiveC", "@com_google_absl//absl/base", "@com_google_absl//absl/log", "@com_google_absl//absl/strings",