Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches in scope? #41

Open
mjl opened this issue Sep 11, 2024 · 2 comments
Open

Patches in scope? #41

mjl opened this issue Sep 11, 2024 · 2 comments

Comments

@mjl
Copy link
Contributor

mjl commented Sep 11, 2024

Over time, I have collected a couple of patches to form-designer, but I'm not sure if I should clean them up for merging or just keep them locked away where nobody sees the horror. Some are a bit hacky by misusing some field configs, for example.

  • Add a datestamp to the file name of export xlsx
  • Refactor form instance creation to add more hooks for easier subclassing/modifying
  • New field types:
    • Static Text (renders a div, misuses the choices/default fields for config)
    • NumberField
    • Captcha with django-simple-captcha
  • Alternative separator for choices so that a choice can contain commas
  • Subject for send_as_mail configurable
  • Force email recipient via setting for integration testing
  • Placeholder for text fields (misuses the choices field)
@matthiask
Copy link
Member

I think all of those are in scope. The choices field should probably be renamed (relabeled) to "choices / placeholder" or something like that.

@mjl
Copy link
Contributor Author

mjl commented Sep 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants