Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on .net standard 2.1 #7

Open
ury opened this issue Nov 23, 2019 · 6 comments
Open

Dependency on .net standard 2.1 #7

ury opened this issue Nov 23, 2019 · 6 comments

Comments

@ury
Copy link

ury commented Nov 23, 2019

Hi,
Is the dependency on .net standard 2.1 and not 2.0 mandatory?
My client project (Blazor) has a strong dependency on .net standard 2.0 and therefore cannot reference the DAL project containing the TemporalTables package.
Thanks,
Ury

@findulov
Copy link
Owner

Hi,
The library relies entirely on Entity Framework Core 3.0 and requires using .net standard 2.1 library.
It is described here: https://docs.microsoft.com/en-us/ef/core/what-is-new/ef-core-3.0/breaking-changes#netstandard21

@ury
Copy link
Author

ury commented Nov 24, 2019

Thanks.
Fortunately, this limitation was removed (at least for the time being) in .NET Core 3.1 (currently in prerelease).
I tested it and it works. May I create a .NET Standard 2.0 / Core 3.1 fork?

@findulov
Copy link
Owner

Sure, go ahead!

@Driedas
Copy link

Driedas commented Apr 23, 2021

@findulov
Hi, thanks for this project, it's exactly what I was looking for but sadly am stuck on dotnetcore 3.1/nestandard 2.1 for at least another year and a half. Would you reconsider upgrading this project to dotnet 5 and instead switching it back to netstandard 2.1? The latest EF core (5.0.5 right now) has a dependency on netstandard 2.1, so the restriction to only support dotnet 5 is not really necessary and potentially reduces the amount of potential adopters for no gain.

I can create my own fork of course and do it there, but it's just so much easier to just use an already existing package.

@findulov
Copy link
Owner

Hi, thanks for using the library. I could update it but I haven't found available time to investigate the new netstandard 2.1 support in .NET 5.0 and I'm afraid not to break something by applying the changes.

It could take me a few days to get this done and if you need this immediately, feel free to fork it right now.

@Driedas
Copy link

Driedas commented Apr 25, 2021

I understand your concerns, however according to the dotnet compatibility matrix (https://docs.microsoft.com/en-us/dotnet/standard/net-standard) both core 3.1 and 5.0 support netstandard 2.1 equally. I will use a fork for now and will switch to your nuget package if you decide to roll the switch back.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants