From ee3640e1605ff67fef4b3d5cd0596f14a6ae73c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= Date: Mon, 3 Jun 2019 12:04:17 +0200 Subject: [PATCH] remove use of like which might cause unwanted side effects (#1787) --- src/Settings/DatabaseSettingsRepository.php | 4 ++-- src/User/UserRepository.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Settings/DatabaseSettingsRepository.php b/src/Settings/DatabaseSettingsRepository.php index d0700a8e57..a74d68c378 100644 --- a/src/Settings/DatabaseSettingsRepository.php +++ b/src/Settings/DatabaseSettingsRepository.php @@ -45,8 +45,8 @@ public function set($key, $value) $query->$method(compact('key', 'value')); } - public function delete($keyLike) + public function delete($key) { - $this->database->table('settings')->where('key', 'like', $keyLike)->delete(); + $this->database->table('settings')->where('key', $key)->delete(); } } diff --git a/src/User/UserRepository.php b/src/User/UserRepository.php index f294a63acf..45611d0dd7 100644 --- a/src/User/UserRepository.php +++ b/src/User/UserRepository.php @@ -75,7 +75,7 @@ public function findByEmail($email) */ public function getIdForUsername($username, User $actor = null) { - $query = User::where('username', 'like', $username); + $query = User::where('username', $username); return $this->scopeVisibleTo($query, $actor)->value('id'); }