Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builder.algotype instead of miner.alogtype for local devnet #127

Open
onlyhyde opened this issue Oct 16, 2023 · 1 comment
Open

Use builder.algotype instead of miner.alogtype for local devnet #127

onlyhyde opened this issue Oct 16, 2023 · 1 comment

Comments

@onlyhyde
Copy link

onlyhyde commented Oct 16, 2023

System information

Geth version: 1.11.5-stable-03ee71cf
OS & Version: Windows/Linux/OSX
Commit hash : (if develop)

Expected behaviour

When we run ./local-builder/devent/devent for test, geth should be work normally

Actual behaviour

geth is terminate with followed log

  • Fatal: Invalid algo in --miner.algotype:

-> use builder.algotype instead of miner.,algotype in ./local-builder/devent/devent script
-> or
-> modified from BuilderAlgoTypeFlag.Name to MinerAlgoTypeFlag.Name in ./cmd/utils/flags.go 1924 line,
-> I think when MinerAlgoTypeFlag is checked, to use MinerAlgoTypeFlag.Name is clear not BulderAlgoTypeFlag.

Steps to reproduce the behaviour

git clone this builder project
cd builder
make
./local-builder/devent/devent run

Backtrace

./local-builder/devnet/devnet run
Creating genesis block
INFO [10-16|14:41:11.603] Maximum peer count                       ETH=50 LES=0 total=50
INFO [10-16|14:41:11.612] Set global gas cap                       cap=50,000,000
INFO [10-16|14:41:11.613] Using leveldb as the backing database
INFO [10-16|14:41:11.614] Allocated cache and file handles         database=/Users/kevin/work/Github/references/mev/builder/local-builder/devnet/data/geth/chaindata cache=16.00MiB handles=16
INFO [10-16|14:41:11.639] Using LevelDB as the backing database
INFO [10-16|14:41:11.675] Opened ancient database                  database=/Users/kevin/work/Github/references/mev/builder/local-builder/devnet/data/geth/chaindata/ancient/chain readonly=false
INFO [10-16|14:41:11.676] Writing custom genesis block
INFO [10-16|14:41:11.677] Persisted trie from memory database      nodes=6 size=850.00B time="93.458µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [10-16|14:41:11.690] Successfully wrote genesis state         database=chaindata hash=961b11..1d70d0
INFO [10-16|14:41:11.691] Using leveldb as the backing database
INFO [10-16|14:41:11.691] Allocated cache and file handles         database=/Users/kevin/work/Github/references/mev/builder/local-builder/devnet/data/geth/lightchaindata cache=16.00MiB handles=16
INFO [10-16|14:41:11.710] Using LevelDB as the backing database
INFO [10-16|14:41:11.746] Opened ancient database                  database=/Users/kevin/work/Github/references/mev/builder/local-builder/devnet/data/geth/lightchaindata/ancient/chain readonly=false
INFO [10-16|14:41:11.746] Writing custom genesis block
INFO [10-16|14:41:11.747] Persisted trie from memory database      nodes=6 size=850.00B time="109.792µs" gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [10-16|14:41:11.751] Successfully wrote genesis state         database=lightchaindata hash=961b11..1d70d0
INFO [10-16|14:41:11.787] Enabling metrics collection
INFO [10-16|14:41:11.787] Enabling stand-alone metrics HTTP endpoint address=127.0.0.1:6060
INFO [10-16|14:41:11.787] Starting metrics server                  addr=http://127.0.0.1:6060/debug/metrics
INFO [10-16|14:41:11.789] Maximum peer count                       ETH=50 LES=0 total=50
Fatal: Invalid algo in --miner.algotype:

When submitting logs: please submit them as text and not screenshots.

@onlyhyde
Copy link
Author

I write how to modified this issue, In Actual behavior.
If it is clearly issue, i can pr to fix.
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant