Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Blacklist Functionality. #135

Open
MPLA101 opened this issue Nov 8, 2023 · 1 comment
Open

Question about Blacklist Functionality. #135

MPLA101 opened this issue Nov 8, 2023 · 1 comment

Comments

@MPLA101
Copy link

MPLA101 commented Nov 8, 2023

As per the README.md, below flag is used to ignore transactions that include mentioned addresses.

--builder.blacklist value : Path to file containing blacklisted addresses, json-encoded list of strings. Builder will ignore transactions that touch mentioned addresses.`

When I checked the code, I see that the Blacklist is only referenced in following functions.
eth/block-validation/api.go:: verifyTransactions
eth/block-validation/api.go:: isBlacklisted
eth/block-validation/api.go:: verifyTraces

All these functions are called from ValidateBuilderSubmissionV2 which in turn is called only when dryRun flag is set.
if b.dryRun {
err = b.validator.ValidateBuilderSubmissionV2 ....

As per my current understanding, the builder exclusively checks for Blacklisted addresses during dryRun mode. If this understanding is accurate, I kindly request that this be explicitly documented for the sake of clarity. Such documentation is essential for users who rely on this feature for regulatory compliance and operational purposes.

@dvush
Copy link
Contributor

dvush commented Feb 22, 2024

Builder uses blacklist for validation and building.

so if you set "--builder.blacklist value" it will be used by the builder (miner module) and it will exclude that txs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants