Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: replace types from go-boost-utils with types from Attestant #404

Closed
metachris opened this issue Nov 9, 2022 · 3 comments
Closed

Comments

@metachris
Copy link
Collaborator

Attestant / @mcdee has been working on up-to-date types with a lot of tests: https://github.com/attestantio/go-eth2-client/tree/master/spec

I'm proposing to switch to the attestandtio types and deprecate the go-boost-utils types.

This would be one less thing to worry about, and one less repository to maintain.

@ralexstokes
Copy link
Collaborator

this works for me, the key things to consider are:

  1. ssz library used
  2. maintainability, reliability of implementation

and it looks like both sources use the same ssz library so (1) is no change and I have no concerns personally about (2)

@prestonvanloon
Copy link

We mentioned this in the Prysm release today. More context can be found here: prysmaticlabs/prysm#11717

@metachris
Copy link
Collaborator Author

work is underway, closing this for now.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants